Closed
Bug 352449
Opened 19 years ago
Closed 19 years ago
better fix for bug 307809 and bug 314502
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Whiteboard: [patch])
Attachments
(1 file)
|
5.87 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
There's a better fix for bug 307809 and bug 314502 -- we can remove the IsBoxFrame check inside nsGrid::GetScrolledBox -- there's no need to have it there, since all frames reflect themselves as boxes now.
|
Assignee | |
Comment 1•19 years ago
|
||
This shouldn't change anything, since nsBox::GetLayoutManager (nsFrame is derived from nsBox) returns null. GetScrolledBox doesn't enforce box-ness for non-scroll-frames, so I don't see any reason why it should do so in the one case when it's walking into scrollframes.
Attachment #238136 -
Flags: superreview?(bzbarsky)
Attachment #238136 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [patch]
|
||
Comment 2•19 years ago
|
||
Comment on attachment 238136 [details] [diff] [review]
patch
Makes sense.
Attachment #238136 -
Flags: superreview?(bzbarsky)
Attachment #238136 -
Flags: superreview+
Attachment #238136 -
Flags: review?(bzbarsky)
Attachment #238136 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•