352562 - nsInstallDlg::XPIProgressCB doesn't worry that its input will fit

Status: RESOLVED INVALID

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[timeless]

https://opensource.klocwork.com/idm/problem.html?project=firefox&pid=91669

as long as no localizer sticks the : early enough in the 63 character buffer and as long as the leaf name combined with the text up to the colon doesn't exceed 63, there's no problem. 

http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsInstallResources.cpp#51 shows the current table and
http://lxr.mozilla.org/seamonkey/source/toolkit/locales/en-US/chrome/global/xpinstall/xpinstall.properties#43
is the toolkit replacement

i suppose a locale could conspire to put the : in a bad place, but if your locale is evil, you're screwed half a dozen other ways, locales have to be trustworthy (even when they're broken, as was the case with a mail crash recently). and you shouldn't be installing xpi's from untrusted sources either.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Pretty sure this is irrelevant now.