Closed Bug 352620 Opened 18 years ago Closed 16 years ago

String literal converted to char* in formal argument name and in initialization

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Platform:
x86
SunOS
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

constify
16.78 KB, patch
Details | Diff | Splinter Review 
Building deps for /export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/src/ScheduledTasks.cpp
"/export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/src/ScheduledTasks.cpp", line 438: Warning: String literal converted to char* in formal argument name in call to NR_RegSetEntry(void*, int, char*, unsigned short, void*, unsigned).
"/export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/src/ScheduledTasks.cpp", line 444: Warning: String literal converted to char* in formal argument name in call to NR_RegSetEntry(void*, int, char*, unsigned short, void*, unsigned).
"/export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/src/ScheduledTasks.cpp", line 572: Warning: String literal converted to char* in formal argument name in call to NR_RegGetEntry(void*, int, char*, void*, unsigned*).
"/export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/src/ScheduledTasks.cpp", line 576: Warning: String literal converted to char* in formal argument name in call to NR_RegGetEntry(void*, int, char*, void*, unsigned*).


"/export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/src/nsInstallResources.cpp", line 90: Warning: String literal converted to char* in initialization.
"/export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/cleanup/InstallCleanup.cpp", line 79: Warning: String literal converted to char* in formal argument name in call to NR_RegGetEntry(void*, int, char*, void*, unsigned*).
"/export/home/timeless/Desktop/0/var/www/html/mxr/lxr-root/lxr-data/seamonkey/mozilla/xpinstall/cleanup/InstallCleanup.cpp", line 97: Warning: String literal converted to char* in formal argument path in call to NR_RegDeleteKey(void*, int, char*).
Attached patch constify — — Splinter Review 
i can fix the whitespace if necessary, i'd probably fix most cases by moving to one parameter per line for function declarations.
Attachment #238386 - Flags: superreview?
Attachment #238386 - Flags: review?
Attachment #238386 - Flags: superreview?(dveditz)
Attachment #238386 - Flags: superreview?
Attachment #238386 - Flags: review?(dveditz)
Attachment #238386 - Flags: review?
Comment on attachment 238386 [details] [diff] [review]
constify

All this stuff is getting ripped out, clearing requests
Attachment #238386 - Flags: superreview?(dveditz)
Attachment #238386 - Flags: review?(dveditz)
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: