phishing warning bubble uses wrong closebutton (on mac)

RESOLVED INVALID

Status

()

RESOLVED INVALID
12 years ago
4 years ago

People

(Reporter: beltzner, Assigned: tony)

Tracking

2.0 Branch
Firefox 2
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The phishing warning bubble still uses the red closebutton instead of the new grey one from the tabstrip and pretty much everywhere else. Screenshot coming.
philor tells me that this might be intentional; if it is, feel free to WONTFIX, but with the understanding that I think it's pretty darned odd.

Comment 3

12 years ago
It's not intentional on our part if that helps anyone make a call on fixing this...
I didn't mean to imply it was intentional, just that it wasn't _exactly_ something we forgot while changing the close button: safebrowsing uses its own fake of the closebutton, in browser/themes/(win|pin)stripe/browser/safebrowsing/close16x16.png, rather than using the images everyone else uses, so

 - it will always look wrong, because it doesn't have inactive/hover/active states
 - it will almost always be forgotten, because changing one image, and searching for references to that image name in CSS, will change every other instance of a close button in the tree, but not that one

And though the difference isn't as obvious in winstripe, it's wrong there too: compare http://lxr.mozilla.org/mozilla1.8/source/browser/themes/winstripe/browser/Close-tab.png and http://lxr.mozilla.org/mozilla1.8/source/browser/themes/winstripe/browser/safebrowsing/close16x16.png
(Assignee)

Comment 5

12 years ago
(In reply to comment #4)
> I didn't mean to imply it was intentional, just that it wasn't _exactly_
> something we forgot while changing the close button: safebrowsing uses its own
> fake of the closebutton, in
> browser/themes/(win|pin)stripe/browser/safebrowsing/close16x16.png, rather than
> using the images everyone else uses, so
> 
>  - it will always look wrong, because it doesn't have inactive/hover/active
> states
>  - it will almost always be forgotten, because changing one image, and
> searching for references to that image name in CSS, will change every other
> instance of a close button in the tree, but not that one

So it sounds like what should be done is to start using the same image as elsewhere and add the hover/active effect.
(Assignee)

Comment 6

12 years ago
Created attachment 238964 [details] [diff] [review]
v1: use tab close icon, add css hover
Assignee: nobody → tony
Status: NEW → ASSIGNED
Attachment #238964 - Flags: review?(mconnor)
Comment on attachment 238964 [details] [diff] [review]
v1: use tab close icon, add css hover

Hahahaha, you asked mconnor for review.

Oh, wait, that's not funny.
Attachment #238964 - Flags: review?(mconnor) → review?(mano)
Comment on attachment 238964 [details] [diff] [review]
v1: use tab close icon, add css hover

>Index: browser/themes/*stripe/browser/safebrowsing/browser-protection.css
>===================================================================

> #safebrowsing-palm-close { 
>   height: 16px; 
>   width: 16px;

You can remove this now, I think.

r=mano otherwise.
Attachment #238964 - Flags: review?(mano) → review+

Comment 9

6 years ago
Phishing popup bubble has been replaced by an in-content error page. Closing as INVALID.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.