Closed
Bug 352626
Opened 18 years ago
Closed 18 years ago
[pinstripe] tabstrip nits: left, right, and all tabs buttons bleed 1 px into tabstrip, 1px gap before scroll buttons, arrow in right scroll button off by 1px
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: moco, Assigned: moco)
References
Details
(Keywords: fixed1.8.1, Whiteboard: [asking for blocking, because #348935 was blocking, see screen shot and comment #2])
Attachments
(6 files)
43.81 KB,
image/jpeg
|
Details | |
65.86 KB,
image/jpeg
|
Details | |
2.07 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
22.29 KB,
image/jpeg
|
Details | |
54.21 KB,
image/jpeg
|
Details | |
7.61 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
[pinstripe] left, right, and all tabs buttons bleed 1 px into tabstrip winstripe does not have this, as it has undergone a lot of cleanup over the past few days. spun off from bug #348935 I'll make some screen shots.
Assignee | ||
Updated•18 years ago
|
Flags: blocking-firefox2?
Whiteboard: [asking for blocking, because #348935 was blocking, but need screen shots first]
Assignee | ||
Comment 1•18 years ago
|
||
Assignee | ||
Comment 2•18 years ago
|
||
on closer inspection, I see the following problems. 1) to the left of the scroll left button, there is a 1 px gap, and the button is not flush with the side of the window 2) on a related note, to the right of the scroll right button there is a 1 px gap, and the button is not flush with the all tabs button 3) the bottoms of the scroll left, scroll right, and all tabs "bleed" into the white strip. the bottom of these button should look like the bottom of a background tab. I'd like to fix all these issues before RC1.
Status: NEW → ASSIGNED
Summary: [pinstripe] left, right, and all tabs buttons bleed 1 px into tabstrip → [pinstripe] tabstrip nits: left, right, and all tabs buttons bleed 1 px into tabstrip, 1px gap before scroll buttons
Whiteboard: [asking for blocking, because #348935 was blocking, but need screen shots first] → [asking for blocking, because #348935 was blocking, see screen shot and comment #2]
Assignee | ||
Comment 3•18 years ago
|
||
Assignee | ||
Comment 4•18 years ago
|
||
Attachment #238445 -
Flags: review?(mconnor)
Attachment #238445 -
Flags: approval1.8.1?
Comment 5•18 years ago
|
||
Comment on attachment 238445 [details] [diff] [review] patch oy! good catch, surprised no one else noticed this!
Attachment #238445 -
Flags: review?(mconnor)
Attachment #238445 -
Flags: review+
Attachment #238445 -
Flags: approval1.8.1?
Attachment #238445 -
Flags: approval1.8.1+
Assignee | ||
Comment 6•18 years ago
|
||
Assignee | ||
Comment 7•18 years ago
|
||
in my next patch, I'll include this fix for that new nit: .scrollbutton-rel-box > .scrollbutton-down > .toolbarbutton-icon { margin-top: 4px; + -moz-margin-start: 1px; }
Summary: [pinstripe] tabstrip nits: left, right, and all tabs buttons bleed 1 px into tabstrip, 1px gap before scroll buttons → [pinstripe] tabstrip nits: left, right, and all tabs buttons bleed 1 px into tabstrip, 1px gap before scroll buttons, arrow in right scroll button off by 1px
Assignee | ||
Comment 8•18 years ago
|
||
> in my next patch, I'll include this fix for that new nit: landed on the branch as part of bug #352518. now on to the bleeding issue!
Comment 9•18 years ago
|
||
I would really, really like this to get in, but I'm actually not sure that it should block release, in a world where that means we hold the ship date. Seth, are you actively working on this right now?
Assignee | ||
Comment 10•18 years ago
|
||
> I would really, really like this to get in, but I'm actually not sure that it
> should block release, in a world where that means we hold the ship date. Seth,
> are you actively working on this right now?
I am working on it right now, yes. (note, this bug covers three issues: bleeding, gaps, and right scroll inner arrow off by 1px. what's left is the bleeding issue)
I agree, it should not block the release or cause a slip. We could ship with it, yes.
I'm working on it as we speak, unless you have another bug you'd rather me work on.
Assignee | ||
Comment 11•18 years ago
|
||
Assignee | ||
Comment 12•18 years ago
|
||
Attachment #238564 -
Flags: review?(mconnor)
Updated•18 years ago
|
Attachment #238564 -
Flags: review?(mconnor)
Attachment #238564 -
Flags: review+
Attachment #238564 -
Flags: approval1.8.1+
Assignee | ||
Comment 13•18 years ago
|
||
fixed. the three nits in this bug, and the nit from bug #348935, should help pinstripe look slightly better, especially to someone who stares it all day zoomed in!
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
You need to log in
before you can comment on or make changes to this bug.
Description
•