Closed
Bug 352689
Opened 18 years ago
Closed 18 years ago
[mac] regression: autodiscovery of search engines is not announced by color change in search bar
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: lc__fc-xx001xx, Assigned: pamg.bugs)
References
()
Details
(Keywords: fixed1.8.1)
Attachments
(6 files)
1.51 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
4.16 KB,
image/tiff
|
Details | |
5.67 KB,
image/png
|
Details | |
6.86 KB,
image/png
|
Details | |
6.88 KB,
image/png
|
Details | |
3.49 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060914 BonEcho/2.0 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060914 BonEcho/2.0 When you visit a page that advertises its search plug-ins so that Fx's autodiscovery finds them, the search bar doesn't announce that by a color change like usual anymore. Just a mac problem. Reproducible: Always Steps to Reproduce: 1. visit http://www.searchplugins.net/pluginlist.aspx 2. Search bar doesn't show that the autodiscovery found search engines Actual Results: Search bar looks like it looks for pages where the autodiscovery doesn't find search plug-ins offered. Expected Results: Color change around the symbol of the current search plug-in announces that autodetection found search plug-ins for installation
Updated•18 years ago
|
Component: Security → Search
QA Contact: firefox → search
Comment 1•18 years ago
|
||
Gavin says that he heard Pam say this was caused by missing a file in a check-in. Confirming for now...
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 2.0 Branch
Assignee | ||
Comment 2•18 years ago
|
||
Regression from 351618. CSS, not a missing file, but I'm working on it.
Target Milestone: --- → Firefox 2
Assignee | ||
Comment 3•18 years ago
|
||
Updates pinstripe to use stacked images instead of button background-images for hover, open, and engine-is-available states too.
Attachment #238466 -
Flags: review?(mconnor)
Attachment #238466 -
Flags: approval1.8.1?
Updated•18 years ago
|
Attachment #238466 -
Flags: review?(mconnor)
Attachment #238466 -
Flags: review+
Attachment #238466 -
Flags: approval1.8.1?
Attachment #238466 -
Flags: approval1.8.1+
Comment 4•18 years ago
|
||
Fixed on branch. /mozilla/browser/themes/pinstripe/browser/searchbar.css 1.4.8.14
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: blocking-firefox2?
Keywords: fixed1.8.1
Resolution: --- → FIXED
Short question: is the triangle supposed to be centered on the blue spot? If so the blue spot is not placed correctly in Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060915 BonEcho/2.0 ID:2006091508 Dex
Comment 6•18 years ago
|
||
attaching this screenshot, i agree that the current implementation looks odd to me on Mac.
Assignee | ||
Comment 7•18 years ago
|
||
Odd -- here's what I see in Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/2006091508 BonEcho/2.0. It looks pretty centered to me.
Comment 9•18 years ago
|
||
That's strange, 'cause mine looks totally different.
Reporter | ||
Comment 10•18 years ago
|
||
change the width of the window, the distance of the triangle to the search engine icon seems to get wider the wider the window, while the spot stays at the same place.
Comment 11•18 years ago
|
||
The width of the searchbar seems to affect the appearance of the splotch. That can't be right.
Assignee | ||
Comment 12•18 years ago
|
||
(In reply to comment #11) > The width of the searchbar seems to affect the appearance of the splotch. That > can't be right. What it's affecting is the distance between the search-engine icon and the left end of the searchbar. The splotch is actually part of the same image that the left end is, so it can't be moving -- but the triangle is. For reference, a 1068-pixel-wide window has an off-center splotch (the icon and triangle are too far right), 1069 pixels also off-center, 1070 through 1072 centered, and 1073 off-center again.
Comment 13•18 years ago
|
||
nominating to get back on the radar.
Status: RESOLVED → REOPENED
Flags: blocking-firefox2?
Resolution: FIXED → ---
Updated•18 years ago
|
Keywords: fixed1.8.1
Assignee | ||
Comment 14•18 years ago
|
||
Okay, apparently the code that centers even-pixel-width XUL objects in an odd-pixel-width box isn't consistent about whether it takes the floor or ceiling for the left margin, and the choice depends on the location of the outer box. So here's a patch that removes the pack="center", sets a hard left margin instead in winstripe, and spaces the triangle out from the favicon properly in pinstripe. I've tested in Mac, Windows, ad Linux, and it looks correct in all the window sizes I've tried.
Attachment #238706 -
Flags: review?(mconnor)
Attachment #238706 -
Flags: approval1.8.1?
Comment 15•18 years ago
|
||
Comment on attachment 238706 [details] [diff] [review] Set left margin rather than centering r+a=me, this needs to go in by 6 PM PDT today, if I don't hear from you by then I'll land it for you :)
Attachment #238706 -
Flags: review?(mconnor)
Attachment #238706 -
Flags: review+
Attachment #238706 -
Flags: approval1.8.1?
Attachment #238706 -
Flags: approval1.8.1+
Comment 16•18 years ago
|
||
I landed this on the branch: mozilla/browser/components/search/content/search.xm 1.37.2.62 mozilla/browser/themes/winstripe/browser/searchbar.css 1.3.8.24 mozilla/browser/themes/pinstripe/browser/searchbar.css 1.4.8.15
Keywords: fixed1.8.1
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Comment 17•18 years ago
|
||
All of the patches here seem to be in on the trunk (the last one due to bug 353673), so I'm guessing that this can be marked FIXED now. Can a mac trunk user confirm?
Comment 18•18 years ago
|
||
Splotch and arrow look exactly alike at 1068 and 1071 pixels in a trunk build from last night.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•