352695 - Custom select fields are mandatory on bug creation (despite they shouldn't be)

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

Try hacking the URL and don't include a custom select field. You get an error thrown by the validator which complains that you didn't give a valid value for this field. We could fix Bugzilla::Bug::_check_select_field() to return the default value if no value is given, except that this means hardcoding '---' in Bug.pm. I wonder if we should set '---' as default in the DB schema.

Comment 1

[Max Kanat-Alexander]

The solution is just to not pass the custom fields in, I think, if they're undef. But just those fields, because other fields should still be passed in, even if they're undef.

It should be an easy fix to the map().

Comment 2

[Olav Vitters]

Attachment: Patch v1

Comment 3

[Frédéric Buclin]

Comment on attachment 242545 [details] [diff] [review]
Patch v1

>+# Undefined custom single select fields are not allowed as undefined is not a
>+# legal value.

Nit: I don't like the "are not allowed" part. This makes me think that I have to define them, always. Maybe should we only say that they are ignored.


>+my @bug_fields = grep { $_->type != FIELD_TYPE_SINGLE_SELECT
>+                        || defined $cgi->param($_->name) } @custom_bug_fields;

err... Why not: grep {defined $cgi->param($_->name)} @custom_bug_fields; only? I didn't test your patch, but I think that all undefined custom fields can be safely ignored.

Comment 4

[Olav Vitters]

Attachment: Patch v2

Changes:
 - Better comment, hopefully
 - Ignores all undefined custom field codes (works)

Comment 5

[Frédéric Buclin]

Comment on attachment 242907 [details] [diff] [review]
Patch v2

>+my @bug_fields = grep { defined $cgi->param($_->name) } @custom_bug_fields;
>+@bug_fields = map { $_->name } @bug_fields;

Nit: you could do a *tiny* simplification by shifting these two lines:

  my @bug_fields = map { $_->name } @custom_bug_fields;
  @bug_fields = grep { defined $cgi->param($_) } @bug_fields;

(we avoid one ->name)

Anyway, your patch is working correctly. r=LpSolit

Comment 6

[Olav Vitters]

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.181; previous revision: 1.180
done