Closed Bug 352713 Opened 14 years ago Closed 14 years ago

Build with official branding creates and calls wrong releaseNotesURL

Categories

(Calendar :: Sunbird Only, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: mattwillis)

References

()

Details

(Keywords: late-l10n)

Attachments

(1 file)

Build with official branding creates and calls wrong releaseNotesURL. The problem seems to happen when replacing the %s with the current version number. Same happens when using one of the language packs from http://ssitter.googlepages.com/langpack that are build official branding.

Actual Results:
http://www.mozilla.org/projects/calendar/releases/sunbird0.html is called

Expected Results:
http://www.mozilla.org/projects/calendar/releases/sunbird0.3a2+.html is called

Additional Information:

Dump statements in openReleaseNotes() shows:

 appInfo.version = 0.3a2+

that is correct but the created and called URL is

 relNotesURL = http://www.mozilla.org/projects/calendar/releases/sunbird0.html

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060914 Calendar/0.3a2+
We can't really ship without this being fixed.
Whiteboard: [needs patch]
Flags: blocking0.3+
These changes also need to be made to brand.properties in each locale. Since people don't localize "Mozilla Sunbird", we should be okay to fix it without busting string freeze.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #238565 - Flags: second-review?(dmose)
Attachment #238565 - Flags: first-review?(dmose)
Whiteboard: [needs patch] → [needs review dmose]
Comment on attachment 238565 [details] [diff] [review]
fixes case of %s to be %S

r1/r2=dmose.  I don't think we gain much from two levels of review on a patch this trivial.
Attachment #238565 - Flags: second-review?(dmose)
Attachment #238565 - Flags: second-review+
Attachment #238565 - Flags: first-review?(dmose)
Attachment #238565 - Flags: first-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk, and in all locales on branch and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs review dmose]
Works with most languages now. Exception: eu, mn, ru still call wrongs URL.

Maybe this should be announced on l10n newsgroup so that all translators can check the files?
Keywords: late-l10n
(In reply to comment #5)
> Works with most languages now. Exception: eu, mn, ru still call wrongs URL.
> 
> Maybe this should be announced on l10n newsgroup so that all translators can
> check the files?

I must've used an old all locales and missed them, although ru has set the relnotes url to something on the mozilla-russia site, so my find/replace didn't work.

I fixed those three locales on both branch and trunk.

You need to log in before you can comment on or make changes to this bug.