352764 - Icons in the location bar show the text (or other non-arrow) cursor when mousing in from outside the location bar

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

From bug 352293:

------- Comment #5 From Stuart Morgan  2006-09-14 07:21 PDT -------

r=me with that change. I find it to only be really reliable if you mouse over
the icon starting from the text area of the location bar, but that's the same
behavior I see with the proxy icon. Is there a bug tracking that issue?  If
not, someone should file one.

--

Yeah, if you come in from the side that's another toolbar item, or above/below, you don't get the arrow cursor on any of the three (favicon, lock, feed)....

1.1 for now, but an early candidate for kicking if nothing materializes....

Comment 1

[Christopher Henderson]

Attachment: Fix v1.0

Patch that overrides the resetCursorRects method in AutoCompleteTextField. Grabs the field's bounds, shrinks them to exclude the icons on each end, then sets the remaining space to have an I-beam cursor.

Comment 2

[Christopher Henderson]

Attachment: Fix v1.1

Realised that since I was taking the logic straight from a related method, I could just call that method instead. Makes this method more future-proof, if we add any more icons.

Comment 3

[Chris Lawson (gone)]

Comment on attachment 336572 [details] [diff] [review]
Fix v1.1

r=me. This looks good and works as advertised.

Comment 4

[Stuart Morgan]

Comment on attachment 336572 [details] [diff] [review]
Fix v1.1

Nice! sr=smorgan

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.