Closed Bug 352773 Opened 18 years ago Closed 18 years ago

DOM Inspector node type still shows tooltip of node type in word form

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jason.barnabe, Assigned: jason.barnabe)

Details

Attachments

(1 obsolete file)

Bug 341816 changed the node type display from a numeric to the word form of the node type. Previously, the display had a tooltip of the word form. We should now remove the tooltip.
Attached patch patch v1 (obsolete) — Splinter Review
The code that fills that tooltip uses nodeTypeToText. The only other caller of that looks like performs the same function in the JavaScript Object view, but I don't see any tooltip showing up there (and I find the usefulness of that questionable). So I've removed both callers and the function itself.
Assignee: dom-inspector → jason_barnabe
Status: NEW → ASSIGNED
Attachment #238581 - Flags: superreview?(neil)
Attachment #238581 - Flags: review?(timeless)
How about removing the node types from inspector.properties as well?
Well that would break the code introduced in bug 341816, wouldn't it?
So it would.  My apologies.
Attachment #238581 - Flags: superreview?(neil) → superreview+
Attachment #238581 - Flags: review?(timeless) → review+
Whiteboard: [checkin needed]
Comment on attachment 238581 [details] [diff] [review]
patch v1

mozilla/extensions/inspector/resources/content/utils.js 	1.16
mozilla/extensions/inspector/resources/content/viewers/domNode/domNode.js 	1.24
mozilla/extensions/inspector/resources/content/viewers/jsObject/jsObjectViewer.js 	1.20
Attachment #238581 - Attachment is obsolete: true
Whiteboard: [checkin needed]
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: