If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

DOM Inspector node type still shows tooltip of node type in word form

RESOLVED FIXED

Status

Other Applications
DOM Inspector
--
minor
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Jason Barnabe (np), Assigned: Jason Barnabe (np))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

11 years ago
Bug 341816 changed the node type display from a numeric to the word form of the node type. Previously, the display had a tooltip of the word form. We should now remove the tooltip.
(Assignee)

Comment 1

11 years ago
Created attachment 238581 [details] [diff] [review]
patch v1

The code that fills that tooltip uses nodeTypeToText. The only other caller of that looks like performs the same function in the JavaScript Object view, but I don't see any tooltip showing up there (and I find the usefulness of that questionable). So I've removed both callers and the function itself.
Assignee: dom-inspector → jason_barnabe
Status: NEW → ASSIGNED
Attachment #238581 - Flags: superreview?(neil)
Attachment #238581 - Flags: review?(timeless)
How about removing the node types from inspector.properties as well?
(Assignee)

Comment 3

11 years ago
Well that would break the code introduced in bug 341816, wouldn't it?
So it would.  My apologies.

Updated

11 years ago
Attachment #238581 - Flags: superreview?(neil) → superreview+

Updated

11 years ago
Attachment #238581 - Flags: review?(timeless) → review+
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]

Comment 5

11 years ago
Comment on attachment 238581 [details] [diff] [review]
patch v1

mozilla/extensions/inspector/resources/content/utils.js 	1.16
mozilla/extensions/inspector/resources/content/viewers/domNode/domNode.js 	1.24
mozilla/extensions/inspector/resources/content/viewers/jsObject/jsObjectViewer.js 	1.20
Attachment #238581 - Attachment is obsolete: true

Updated

11 years ago
Whiteboard: [checkin needed]
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.