Closed
Bug 352773
Opened 18 years ago
Closed 18 years ago
DOM Inspector node type still shows tooltip of node type in word form
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jason.barnabe, Assigned: jason.barnabe)
Details
Attachments
(1 obsolete file)
Bug 341816 changed the node type display from a numeric to the word form of the node type. Previously, the display had a tooltip of the word form. We should now remove the tooltip.
Assignee | ||
Comment 1•18 years ago
|
||
The code that fills that tooltip uses nodeTypeToText. The only other caller of that looks like performs the same function in the JavaScript Object view, but I don't see any tooltip showing up there (and I find the usefulness of that questionable). So I've removed both callers and the function itself.
Assignee: dom-inspector → jason_barnabe
Status: NEW → ASSIGNED
Attachment #238581 -
Flags: superreview?(neil)
Attachment #238581 -
Flags: review?(timeless)
Comment 2•18 years ago
|
||
How about removing the node types from inspector.properties as well?
Assignee | ||
Comment 3•18 years ago
|
||
Well that would break the code introduced in bug 341816, wouldn't it?
Comment 4•18 years ago
|
||
So it would. My apologies.
Updated•18 years ago
|
Attachment #238581 -
Flags: superreview?(neil) → superreview+
Attachment #238581 -
Flags: review?(timeless) → review+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment on attachment 238581 [details] [diff] [review] patch v1 mozilla/extensions/inspector/resources/content/utils.js 1.16 mozilla/extensions/inspector/resources/content/viewers/domNode/domNode.js 1.24 mozilla/extensions/inspector/resources/content/viewers/jsObject/jsObjectViewer.js 1.20
Attachment #238581 -
Attachment is obsolete: true
Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
QA Contact: timeless → dom-inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•