352782 - Help toolbar's Home icon jumps up a pixel when clicked

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20060914 BonEcho/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20060914 BonEcho/2.0

Refer the Screenshot. Problems are as below:

- Home icon is not centered upon Hover
- Print icon is not centered upon Hover
- Home icon moves up a few pixels when pressed while Print icon doesn't



Reproducible: Always

Comment 1

[ronin.achilles]

Attachment: Help Toolbar Inconsistency

Screenshot showing the problems

Comment 2

[ronin.achilles]

(In reply to comment #1)
> Created an attachment (id=238589) [edit]
> Help Toolbar Inconsistency
> 
> Screenshot showing the problems
> 

Two different images have been placed side by side to show the moving up of Home Icon in 'pressed' state while the same thing does not happen to Print icon.

Comment 3

[Phil Ringnalda (:philor)]

That's actually two separate bugs: one piece of the image in the wrong place, and some broken CSS. Filed bug 354017 for the off-center buttons.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: /toolkit/themes/winstripe/help/Toolbar.png

Active Home icon moved down 1px, to be in the same part of the region as the other versions of it.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: /toolkit/themes/winstripe/help/Toolbar-rtl.png

rtl version

Comment 6

[Asaf Romano (gone)]

Comment on attachment 239873 [details]
/toolkit/themes/winstripe/help/Toolbar.png

assuming you've tested both, r=mano.

Comment 7

[Asaf Romano (gone)]

1.8
mozilla/toolkit/themes/winstripe/help/Toolbar-rtl.png  1.1.2.5
mozilla/toolkit/themes/winstripe/help/Toolbar.png 1.4.2.6

Comment 8

[Asaf Romano (gone)]

mozilla/toolkit/themes/winstripe/help/Toolbar-rtl.png 1.3
mozilla/toolkit/themes/winstripe/help/Toolbar.png 1.6