352786 - Round-trip bracing change for "{ if(0) let x; }"

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

The entire if block is removed because the condition is always false, but the braces stick around for the phantom "let" declaration.

js> function() { { if(0) let x; } }
function () {
    {
    }
}

js> function () {
    {
    }
}
function () {
}

Comment 1

[Jesse Ruderman]

Wait... the "let" shouldn't disappear entirely!  Its scope (currently?) goes beyond the "if" so it needs to stick around.

js> function( ){ if (false) let x }
function () {
}

Comment 2

[Jesse Ruderman]

Fixed by making let |not| directly inside a block be a syntax error (bug 408957).

Comment 3

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/public-failures.txt
new revision: 1.23; previous revision: 1.22

/cvsroot/mozilla/js/tests/js1_7/block/regress-352786.js
initial revision: 1.1

Comment 4

[Bob Clary [:bc] (inactive)]

v