Closed Bug 352858 Opened 18 years ago Closed 18 years ago

Make iMIP bar styling match that of other notification bars (junk, phishing...)

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Lightning 0.3

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

(Whiteboard: [cal-ui-review+])

Attachments

(3 files, 1 obsolete file)

Currently the iMIP bar in Lightning doesn't match the other notification bars. We should fix that.
Attached patch Updates imipbar — — Splinter Review
Screenshots forthcoming.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #238654 - Flags: second-review?(dmose)
Attachment #238654 - Flags: first-review?(cmtalbert)
Attached image Mac screenshot —
Attached image Screenshot of UI on windows (obsolete) —
Screenshot of UI on windows. We need a better icon. But you can see that this size is better because it is the same size as the Junk mail etc icons for the Tbird notification bar.
Attached image Better shot of windows build —
This is a better shot using the proper icon. Again, note that we are now the same size as the junk mail icon.
Attachment #238692 - Attachment is obsolete: true
Comment on attachment 238654 [details] [diff] [review]
Updates imipbar

r+ with the only nit being that the line:
+    font-weight: bold;
in calendar/lightning/themes/winstripe/lightning.css
should be removed.
Attachment #238654 - Flags: first-review?(cmtalbert) → first-review+
Comment on attachment 238654 [details] [diff] [review]
Updates imipbar

r=dmose; looks nice!
Attachment #238654 - Flags: second-review?(dmose) → second-review+
Whiteboard: [cal-ui-review+]
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Component: Lightning Only → E-mail based Scheduling (iTIP/iMIP)
QA Contact: lightning → email-scheduling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: