Port over some FeedWriter improvements from bug 350615 to trunk

RESOLVED FIXED in Firefox 3 alpha1

Status

P2
normal
RESOLVED FIXED
13 years ago
a month ago

People

(Reporter: mano, Assigned: mano)

Tracking

Trunk
Firefox 3 alpha1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Port over some FeedWriter improvements from bug 350615 to trunk
Assignee: nobody → mano
Priority: -- → P2
Target Milestone: --- → Firefox 3 alpha1
Status: NEW → ASSIGNED
Attachment #238753 - Flags: review?(mconnor) → review?(gavin.sharp)
Comment on attachment 238753 [details] [diff] [review]
patch

>Index: browser/components/feeds/src/FeedWriter.js

>   /**
>+   * Helper method to set the selected application and system default
>+   * reader menuitems details from a file object
>+   *   @param aMenuItem
>+   *          The menuitem on which the attributes should be set
>+   *   @param aFile
>+   *          the menuitem associated file object

How about: "The menuitem's associated file" ?

>       if (defaultReader.exists()) {
>         menuItem = this._document.createElementNS(XUL_NS, "menuitem");
>-        menuItem.id = "defaultHandlerMenuItem";
>-        menuItem.className = "menuitem-iconic";

I don't think you want to be removing these. r=me with this reverted.
Attachment #238753 - Flags: review?(gavin.sharp) → review+
Created attachment 239066 [details] [diff] [review]
patch for checkin

mozilla/browser/components/feeds/content/subscribe.xhtml 1.13
mozilla/browser/components/feeds/src/FeedWriter.js 1.18
Attachment #238753 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
OS: Mac OS X 10.3 → All
Hardware: Macintosh → All
Version: unspecified → Trunk

Updated

a month ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.