352935 - Port over some FeedWriter improvements from bug 350615 to trunk

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

Description

[Asaf Romano (gone)]

Port over some FeedWriter improvements from bug 350615 to trunk

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 238753 [details] [diff] [review]
patch

>Index: browser/components/feeds/src/FeedWriter.js

>   /**
>+   * Helper method to set the selected application and system default
>+   * reader menuitems details from a file object
>+   *   @param aMenuItem
>+   *          The menuitem on which the attributes should be set
>+   *   @param aFile
>+   *          the menuitem associated file object

How about: "The menuitem's associated file" ?

>       if (defaultReader.exists()) {
>         menuItem = this._document.createElementNS(XUL_NS, "menuitem");
>-        menuItem.id = "defaultHandlerMenuItem";
>-        menuItem.className = "menuitem-iconic";

I don't think you want to be removing these. r=me with this reverted.

Comment 3

[Asaf Romano (gone)]

Attachment: patch for checkin

mozilla/browser/components/feeds/content/subscribe.xhtml 1.13
mozilla/browser/components/feeds/src/FeedWriter.js 1.18