352939 - [reflow branch] FixedTableLayoutStrategy::ComputeColumnWidth division on zero, on spreadsheets.google.com

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Oleg Romashin (:romaxa)]

Reflow branch crashes on spreadsheets.google.com in:
FixedTableLayoutStrategy.cpp:
.............................
    } else if (unassignedSpace > 0) {
        // The spec says to distribute extra space evenly.  (That's not
        // what WinIE6 does, though.  It treats percentages and
        // nonpercentages differently.)
>>>>>   nscoord toAdd = unassignedSpace / colCount;
        for (PRInt32 col = 0; col < colCount; ++col) {
            nsTableColFrame *colFrame = mTableFrame->GetColFrame(col);
            colFrame->SetFinalWidth(colFrame->GetFinalWidth() + toAdd);
        }
.............................

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Possible fix...

Comment 2

[Bernd]

Comment on attachment 238758 [details] [diff] [review]
Possible fix...

I would however have written

if (!colCount) 
  return; // No Columns - nothing to compute

// XXX Should only add columns that have cells originating in them!
nscoord subtract = spacing * (colCount + 1);
         tableWidth -= subtract;

Comment 3

[Bernd]

we do  not crash on trunk as the corresponding division is wrapped by a
for (colX = 0; colX <colCount; colX++)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed on branch.  Thanks for the patch!