352945 - [mac] with phishing protection warning icon the location bar gets 2px higher and a part of the contour vanishes

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[dex_sf]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060915 BonEcho/2.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060915 BonEcho/2.0

When the phishing protection warning icon appears in the location bar it gets 2 px higher and apparently because of that a part of its contour vanishes, which seems to be covered by the safe browsing popup tail now.

Reproducible: Always

Steps to Reproduce:
1. go to http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html
2. look at location bar


Actual Results:  
The location bar gets 2 px higher and a part of its contour vanishes, apparently covered by the safe browsing popup tail.

Expected Results:  
The location bar should stay as high as always and its contour should by displayed correctly.

Comment 1

[dex_sf]

Attachment: screenshot of the problem

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Bandaid

This isn't perfect, but at least it's extremely minimal, and unbreaks things. The tail comes out of the right side of the icon, instead of the middle, but that still strikes me as better than changing the size of the whole addressbar.

Comment 3

[Phil Ringnalda (:philor)]

Attachment: "After" screenshot

Obligatory screenshot.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 238936 [details] [diff] [review]
Bandaid

I, uh, feel dumb.  I fixed this for the security icon last week, and forgot to check this.

Comment 5

[Asaf Romano (gone)]

1.8
mozilla/browser/themes/pinstripe/browser/safebrowsing/browser-protection.css 1.1.2.8