353065 - /support/thunderbird/keyboard has incorrect Linux shortcuts

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Chris Ilias [:cilias]]

A couple of Linux users have pointed out to me, that the 'Search Messages' shortcut on <http://www.mozilla.org/support/thunderbird/keyboard> is incorrect (for Linux).
Currently, the page says the shortcut for Linux is "Ctrl+Shift+F".
I've been told that it is "Shift+F".

Comment 1

[Chris Ilias [:cilias]]

"Mark All Read" should be Shift+C

Comment 2

[Nir]

Confirmed.
I'm using Thunderbird-1.5.0.7 [Fedora Core release 5 (Bordeaux) , Kernel : 2.6.15-1.2054_FC5] 

Comment 3

[Nir]

Attachment: Screen shot of 'Search Messages' Menu

Created a screen shot of 'Search Messages' Menu ( View>Find>Search Messages )

Comment 4

[Nir]

Attachment: Screen shot of 'All read' Menu

Created a Screen shot of 'All read' Menu ( Message > Mark > All Read )

Comment 5

[Chris Ilias [:cilias]]

I should be able to fix the code, but from what I can tell, it's going to require adding another class, which means editing the four CSS files. I'll need to learn how to create a CVS diff, that edits more than one file (five, to be exact).

Simply hiding the "Ctrl/Cmd" can be hidden for Linux view, but 'All operating systems' view will still be incorrect, so I'm going to list them separately, similar to "New Message".
IOW;
Ctrl/Cmd+Shift+C Win/Mac
Shift+C Linux

Comment 6

[Chris Ilias [:cilias]]

Attachment: attempted patch using WinCVS

Hopefully this is a working way to patch more than one file. :-)

Comment 7

[Chris Ilias [:cilias]]

Comment on attachment 239124 [details] [diff] [review]
attempted patch using WinCVS

I don't want this patch waiting around for six weeks to be reviewed, like in bug 327750.

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> (From update of attachment 239124 [details] [diff] [review] [edit])
> I don't want this patch waiting around for six weeks to be reviewed, like in
> bug 327750.

Can you use unified diffs for your patches? Basically, give diff the "-u" option.

Comment 9

[Chris Ilias [:cilias]]

Attachment: unified diff of first draft

Okay, I'm pretty sure this new one is a unified diff.
(Thanks for responding, Reed. :-) )

Comment 10

[Reed Loden [:reed]]

Comment on attachment 239418 [details] [diff] [review]
unified diff of first draft

This looks ok to me, but I haven't tested it on my staging server. I trust your edits. I will commit this shortly.

r=reed

Comment 11

[Reed Loden [:reed]]

Checking in allkeys.css;
/cvsroot/mozilla-org/html/support/thunderbird/allkeys.css,v  <--  allkeys.css
new revision: 1.3; previous revision: 1.2
done
Checking in keyboard.html;
/cvsroot/mozilla-org/html/support/thunderbird/keyboard.html,v  <--  keyboard.html
new revision: 1.10; previous revision: 1.9
done
Checking in linuxkeys.css;
/cvsroot/mozilla-org/html/support/thunderbird/linuxkeys.css,v  <--  linuxkeys.css
new revision: 1.3; previous revision: 1.2
done
Checking in mackeys.css;
/cvsroot/mozilla-org/html/support/thunderbird/mackeys.css,v  <--  mackeys.css
new revision: 1.3; previous revision: 1.2
done
Checking in winkeys.css;
/cvsroot/mozilla-org/html/support/thunderbird/winkeys.css,v  <--  winkeys.css
new revision: 1.3; previous revision: 1.2
done

Once you get used to using CVS, feel free to apply for CVS access. I know that both ss and myself would be glad to vouch for you. The only thing I noticed in your patch is that is was using the DOS line terminators, which can cause problems. In most all cases, patches and files should use unix line terminators.

You might want to try TortoiseCVS over WinCVS.

As usual, please verify that this patch has fixed the issue when the changes reach stage/production.

Comment 12

[Chris Ilias [:cilias]]

v

Will simply switching to TortoiseCVS take care of the line terminator problem?