353185 - The line-height of the location bar is wrong with Japanese font

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

See following screenshot.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot#1

See the location bar. The descent is cut.(You cannot see 'g').

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

The Japanese font returns 0 for internal leading. But the actual line-height is not equal to emHeight (== size). Therefore, we should calculate the actual internal leading like gfxPangoFont.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 239052 [details] [diff] [review]
Patch rv1.0

I found another approach. I'll create new patch.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv2.0

We should use this patch.

The XP code checking whether the leading is zero for calculating the actual value of 'line-height: normal;' in nsHTMLReflowState.
And we should use new font leading API if thebes is enabled for this issue.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot#2 (patched build)

This is a screenshot of the patched build.
The location bar draws the URI clearly. And the summaries of the bugs in bugzilla-jp are rendered good.(The line-height is normal and the result is similar to old gfx and Safari.)

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 239072 [details] [diff] [review]
Patch rv2.0

Ah!  That explains the location bar issues, especially on mac.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in. thanks.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

backed-out the patch that is cause of bustage on Linux.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Vlad:

If the Linux uses the gfx/src/ps, we fail to build on Linux. But should we use the Legacy gfx code on cairo-gtk2 build?

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv3.0

I'm adding a quirks API in the nsFontMetricsPS.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I want to add the new APIs on Linux. Because we have Bug 218032. I think that we need the new APIs for calculating the suitable line-height. See this code: http://lxr.mozilla.org/mozilla/source/layout/generic/nsHTMLReflowState.cpp#2220
This code is only used |#ifdef FONT_LEADING_APIS_V2|.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in, thank you, vlad.