Closed
Bug 353185
Opened 18 years ago
Closed 18 years ago
The line-height of the location bar is wrong with Japanese font
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(3 files, 2 obsolete files)
See following screenshot.
Assignee | ||
Comment 1•18 years ago
|
||
See the location bar. The descent is cut.(You cannot see 'g').
Assignee | ||
Comment 2•18 years ago
|
||
The Japanese font returns 0 for internal leading. But the actual line-height is not equal to emHeight (== size). Therefore, we should calculate the actual internal leading like gfxPangoFont.
Attachment #239052 -
Flags: review?(vladimir)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 239052 [details] [diff] [review] Patch rv1.0 I found another approach. I'll create new patch.
Attachment #239052 -
Flags: review?(vladimir) → review-
Assignee | ||
Comment 4•18 years ago
|
||
We should use this patch. The XP code checking whether the leading is zero for calculating the actual value of 'line-height: normal;' in nsHTMLReflowState. And we should use new font leading API if thebes is enabled for this issue.
Attachment #239052 -
Attachment is obsolete: true
Attachment #239072 -
Flags: review?(vladimir)
Assignee | ||
Comment 5•18 years ago
|
||
This is a screenshot of the patched build. The location bar draws the URI clearly. And the summaries of the bugs in bugzilla-jp are rendered good.(The line-height is normal and the result is similar to old gfx and Safari.)
Updated•18 years ago
|
Summary: The line-height is wrong with Japanese font → The line-height of the location bar is wrong with Japanese font
Comment on attachment 239072 [details] [diff] [review] Patch rv2.0 Ah! That explains the location bar issues, especially on mac.
Attachment #239072 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 7•18 years ago
|
||
checked-in. thanks.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•18 years ago
|
||
backed-out the patch that is cause of bustage on Linux.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•18 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 9•18 years ago
|
||
Vlad: If the Linux uses the gfx/src/ps, we fail to build on Linux. But should we use the Legacy gfx code on cairo-gtk2 build?
Assignee | ||
Comment 10•18 years ago
|
||
I'm adding a quirks API in the nsFontMetricsPS.
Attachment #239072 -
Attachment is obsolete: true
Attachment #241689 -
Flags: review?(vladimir)
Assignee | ||
Comment 11•18 years ago
|
||
I want to add the new APIs on Linux. Because we have Bug 218032. I think that we need the new APIs for calculating the suitable line-height. See this code: http://lxr.mozilla.org/mozilla/source/layout/generic/nsHTMLReflowState.cpp#2220 This code is only used |#ifdef FONT_LEADING_APIS_V2|.
Attachment #241689 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 12•18 years ago
|
||
checked-in, thank you, vlad.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•