353285 - nsresult rv used unitialized in nsXMLHttpRequest::Open

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[timeless]

https://opensource.klocwork.com/idm/problem.html?project=firefox&pid=93069

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch

First try at a simple patch, early breakout if !cc, rv initialized as NS_OK.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 239318 [details] [diff] [review]
Patch

>Index: nsXMLHttpRequest.cpp
>+  if (!cc) {
>+    return NS_ERROR_FAILURE;
>+  }

No, this is wrong.  That will make it completely impossible to do XMLHttpRequest from C++, which is highly undesirable.

Comment 3

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch 2

Second try.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in.  Thanks for the patch!