Closed
Bug 353351
Opened 18 years ago
Closed 11 years ago
component in enter_bug is case sensitive
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: bugzilla, Assigned: koosha.khajeh)
Details
Attachments
(1 file)
666 bytes,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
This one doesn't select Comp1 as component http://landfill.bugzilla.org/bugzilla-tip/enter_bug.cgi?product=MyOwnBadSelf&component=comp1 while this does: http://landfill.bugzilla.org/bugzilla-tip/enter_bug.cgi?product=MyOwnBadSelf&component=Comp1 that's inconsistent with these where component isn't case sensitive http://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?query_format=specific&bug_status=__open__&product=MyOwnBadSelf&component=comp1 http://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?query_format=specific&bug_status=__open__&product=MyOwnBadSelf&component=Comp1 I'm not sure if there's more places
Comment 1•18 years ago
|
||
Yeah, this is because JavaScript is case-sensitive and MySQL is not.
Severity: normal → minor
OS: Windows XP → All
Hardware: PC → All
Attachment #651526 -
Flags: review?(glob)
Comment on attachment 651526 [details] [diff] [review] patch - v1 r=glob
Attachment #651526 -
Flags: review?(glob) → review+
Assignee: create-and-change → koosha.khajeh
Flags: approval?
Target Milestone: --- → Bugzilla 4.4
Updated•12 years ago
|
Flags: approval? → approval+
Comment 4•12 years ago
|
||
Ah no, wait. The .lower virtual method only exists since TT 2.24, but we require 2.22. So for 2.22 and 2.23, this method is not recognized and the last element from the select field is always selected.
Flags: approval+ → approval?
Updated•12 years ago
|
Flags: approval?
Comment 5•12 years ago
|
||
Comment on attachment 651526 [details] [diff] [review] patch - v1 If we want to use .lower, we have to require TT 2.24. But it's not OK to require 2.24 for Bugzilla 4.4, because it was released a few months ago only, and many distros don't have it yet.
Attachment #651526 -
Flags: review-
Updated•12 years ago
|
Target Milestone: Bugzilla 4.4 → Bugzilla 5.0
Well, if you're going to include this change in 5.0, why r-? Or, if r-, why 4.4 -> 5.0?! :-)
Comment 7•12 years ago
|
||
(In reply to Koosha Khajeh Moogahi [:koosha] from comment #6) > Well, if you're going to include this change in 5.0, why r-? Or, if r-, why > 4.4 -> 5.0?! :-) Your patch must also change the min version of Template::Toolkit in Bugzilla/Install/Requirements.pm, which is why I r- your patch. We are going to release Bugzilla 4.4 soon, and TT 2.24 is too recent to require it in 4.4, which is why I retargetted this bug to 5.0. For 5.0, I'm fine to require TT 2.24 as this will also fix https://rt.cpan.org/Public/Bug/Display.html?id=47929. mkanat said in bug 372979 comment 16 that Bugzilla was affected by this problem when a vote confirms a bug, but I just tried and I cannot reproduce his issue.
Comment 8•11 years ago
|
||
Comment on attachment 651526 [details] [diff] [review] patch - v1 Bugzilla 5.0 now requires TT 2.24 thanks to bug 812220, so this patch is now fine.
Attachment #651526 -
Flags: review-
Updated•11 years ago
|
Flags: approval+
Comment 10•11 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified template/en/default/bug/create/create.html.tmpl Committed revision 8532.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•