Closed Bug 353356 Opened 14 years ago Closed 9 years ago

rv is uninitialized because flushTransaction doesn't handle eEndDocumentTransaction in switch

Categories

(Core :: XSLT, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, klocwork)

Attachments

(1 file)

Assignee: xslt → nobody
QA Contact: keith → xslt
Attached patch initialize rvSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #430924 - Flags: review?(jonas)
Comment on attachment 430924 [details] [diff] [review]
initialize rv

Hmm.. actually, I think this is the wrong fix. I don't see why we wouldn't need to handle endDocumentTransactions in the same switch statement.
Attachment #430924 - Flags: review+ → review-
(In reply to comment #2)
> (From update of attachment 430924 [details] [diff] [review])
> Hmm.. actually, I think this is the wrong fix. I don't see why we wouldn't need
> to handle endDocumentTransactions in the same switch statement.

How could that happen? endDocument is called after the transform is done, we surely must have flushed by then?
If that is true (which is what I suspect is the case too), then we should remove the txBufferingHandler::endDocument implementation, and possibly remove the enum value too unless that's used elsewhere.
The code in question has been removed in this changeset: <http://hg.mozilla.org/mozilla-central/rev/a6822a5df633>
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.