Closed
Bug 353403
Opened 18 years ago
Closed 18 years ago
###!!! ASSERTION: Oops! You're asking for a weak reference to an object that doesn't support that. - code in browser.xml trying to remove the browser:purge-session-history observer
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: asqueella, Assigned: asqueella)
Details
(Keywords: assertion)
Attachments
(1 file)
|
3.79 KB,
patch
|
Gavin
:
first-review+
|
Details | Diff | Splinter Review |
This may happen in case sessionHistory initialization in constructor fails (e.g. with the current version of the XUL editor in Extension Developer's Extension, which has a chrome <browser/>).
|
Assignee | |
Comment 1•18 years ago
|
||
* Make sure we always register the observer in case of !this.hasAttribute("disablehistory").
* Also prevent observer from throwing in case there's no session history
* Don't swallow exceptions from session history initialization.
* Other cleanupAssignee: nobody → asqueella
Status: NEW → ASSIGNED
Attachment #239263 -
Flags: first-review?(gavin.sharp)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 239263 [details] [diff] [review] patch r=me, though last I checked I'm not a toolkit peer :)
Attachment #239263 -
Flags: first-review?(gavin.sharp) → first-review+
|
|
||
Updated•18 years ago
|
Whiteboard: [checkin needed]
|
|
||
Comment 3•18 years ago
|
||
mozilla/toolkit/content/widgets/browser.xml 1.93
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha1
You need to log in
before you can comment on or make changes to this bug.
Description
•