###!!! ASSERTION: Oops! You're asking for a weak reference to an object that doesn't support that. - code in browser.xml trying to remove the browser:purge-session-history observer

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Nickolay_Ponomarev, Assigned: Nickolay_Ponomarev)

Tracking

({assertion})

Trunk
mozilla1.9alpha1
assertion
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
This may happen in case sessionHistory initialization in constructor fails (e.g. with the current version of the XUL editor in Extension Developer's Extension, which has a chrome <browser/>).
(Assignee)

Comment 1

12 years ago
Created attachment 239263 [details] [diff] [review]
patch

* Make sure we always register the observer in case of !this.hasAttribute("disablehistory").
* Also prevent observer from throwing in case there's no session history
* Don't swallow exceptions from session history initialization.
* Other cleanup
Assignee: nobody → asqueella
Status: NEW → ASSIGNED
Attachment #239263 - Flags: first-review?(gavin.sharp)
Comment on attachment 239263 [details] [diff] [review]
patch

r=me, though last I checked I'm not a toolkit peer :)
Attachment #239263 - Flags: first-review?(gavin.sharp) → first-review+
Whiteboard: [checkin needed]
mozilla/toolkit/content/widgets/browser.xml 	1.93
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha1
You need to log in before you can comment on or make changes to this bug.