Closed Bug 353410 Opened 14 years ago Closed 14 years ago

useless null check in nsPrintEngine::SetupToPrintContent

Categories

(Core :: Printing: Output, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: timeless, Assigned: sciguyryan)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

we'd already crash by the time we null check.
Attached patch PatchSplinter Review
First try at _any_ patch - tried this first because it seemed simple enough (if I understood correctly anyway.)
Comment on attachment 239274 [details] [diff] [review]
Patch

Not shure if these are the correct reviewers - if not please change - thanks!
Attachment #239274 - Flags: superreview?(dbaron)
Attachment #239274 - Flags: review?(roc)
Comment on attachment 239274 [details] [diff] [review]
Patch

great, thanks!

Get someone on irc.mozilla.org #developers to check it in for you.
Attachment #239274 - Flags: superreview?(dbaron)
Attachment #239274 - Flags: superreview+
Attachment #239274 - Flags: review?(roc)
Attachment #239274 - Flags: review+
Whiteboard: [checkin needed]
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This hadn't actually been checked in yet, I just did that now...
mozilla/layout/printing/nsPrintEngine.cpp 	1.126
Assignee: printing → sciguyryan+bugzilla
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
OS: Linux → All
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.