Closed
Bug 353410
Opened 19 years ago
Closed 19 years ago
useless null check in nsPrintEngine::SetupToPrintContent
Categories
(Core :: Printing: Output, defect)
Core
Printing: Output
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: timeless, Assigned: sciguyryan)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
896 bytes,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
we'd already crash by the time we null check.
|
Assignee | |
Comment 1•19 years ago
|
||
First try at _any_ patch - tried this first because it seemed simple enough (if I understood correctly anyway.)
|
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 239274 [details] [diff] [review]
Patch
Not shure if these are the correct reviewers - if not please change - thanks!
Attachment #239274 -
Flags: superreview?(dbaron)
Attachment #239274 -
Flags: review?(roc)
Comment on attachment 239274 [details] [diff] [review]
Patch
great, thanks!
Get someone on irc.mozilla.org #developers to check it in for you.
Attachment #239274 -
Flags: superreview?(dbaron)
Attachment #239274 -
Flags: superreview+
Attachment #239274 -
Flags: review?(roc)
Attachment #239274 -
Flags: review+
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•19 years ago
|
||
This hadn't actually been checked in yet, I just did that now...
mozilla/layout/printing/nsPrintEngine.cpp 1.126
Assignee: printing → sciguyryan+bugzilla
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
|
|
||
Updated•19 years ago
|
OS: Linux → All
Whiteboard: [checkin needed]
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•