353421 - autocomplete is broken

Status: VERIFIED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Ben Willmore]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; chrome://navigator/locale/navigator.properties; rv:1.9a1) Gecko/20060918 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; chrome://navigator/locale/navigator.properties; rv:1.9a1) Gecko/20060918 Camino/1.2+

On 1.2+ 20060918, no autocomplete suggestions are made when a URL is typed.  Nor is there a dropdown.  Autocomplet works normally on 1.2+ 20060915

Reproducible: Always

Comment 1

[froodian (Ian Leue)]

Yeah, I see this in my own Camino trunk build, pulled last night, as well.

Comment 2

[Samuel Sidler (old account; do not CC)]

I'm just going to go out on a limb and say that this was caused by bug 341504. CCing appropriate people.

(I'm also CCing Håkan as this bug might not be relevant if we switch to a Cocoa version of autocomplete, right?)

Comment 3

[[e-mail]]

AutoCompleteTextField.mm has hardcoded the contract ID that it uses but AppComponents.mm is using XPFE's #define which I changed in bug 341504.

The simple fix is simply to hardcode the same contract ID.
An alternative fix is to remove that contract ID from AppComponents.mm, change the constructor into a simple constructor, and use the CID or other contract ID in AutoCompleteTextField.mm
Another fix is again to remove that contract ID from AppComponents.mm but make AutoCompleteTextField.mm to call the singleton getter directly.

Comment 4

[Håkan Waara]

Attachment: Fix

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 239389 [details] [diff] [review]
Fix

sr=pink

Comment 6

[Chris Lawson (gone)]

verified w/ 22 Sep trunk nightly