353437 - Need to localize file-type filter in Alarms dialog

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Adam Guthrie]

Filed as a follow-up to bug 352674.

Right now we hard-code the filter name to "*.wav". We need to add a string such as "WAV Files (*.wav)" to calendar.properties and use that.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: localizes the label.

To reviewers: Test on Linux or Win32. Mac doesn't show this label.

Comment 2

[cmtalbert]

Comment on attachment 241975 [details] [diff] [review]
localizes the label.

Did not run a build. But, the fix looks good to me. I did ask some questions as to the rationale behind the method used to get the localized resource in the XUL file, but several other preference files do this too. The preference files in general seem to be a good candidate for streamlining code w.r.t. localized strings, but that is outside the scope of this simple fix.

I'm not clear on the scope that wavFileLabel obtains from this sort of declaration, if it is a global, then my nit would be to "namespace" it by changing it to gWavFilePrefLabel or wavFilePrefLabel -- something that can be sure to never conflict with any new development. 

It should be noted that wavFileLabel does not occur anywhere in our current calendar/ codebase, however.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 241975 [details] [diff] [review]
localizes the label.

Unless I'm mistaken, this wants to live in a string bundle, not a DTD.

Comment 4

[Matthew (lilmatt) Willis]

Attachment: now with 100% less stupid!

Stringbundles. Yum.

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 242240 [details] [diff] [review]
now with 100% less stupid!

carrying forward ctalbert's review

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED