Closed
Bug 353506
Opened 18 years ago
Closed 18 years ago
Swat namesx strict warnings
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rdmsoft, Assigned: rdmsoft)
Details
(Whiteboard: [cz-0.9.76])
Attachments
(1 file)
|
1014 bytes,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
Patch in a sec.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #239350 -
Flags: review?(silver)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 239350 [details] [diff] [review] fix >- if (this.supports.namesx) >+ if ("namesx" in this.supports && this.supports.namesx) Nit: please use parentheses around the 'in' clause, for visual clarity. >- } while (found && this.supports.namesx); >+ } while (found && "namesx" in this.supports && this.supports.namesx); Nit: same. r=silver with those changes.
Attachment #239350 -
Flags: review?(silver) → review+
|
||
Comment 3•18 years ago
|
||
Checked in with nits fixed: Checking in mozilla/extensions/irc/js/lib/irc.js; /cvsroot/mozilla/extensions/irc/js/lib/irc.js,v <-- irc.js new revision: 1.101; previous revision: 1.100 done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Updated•18 years ago
|
Whiteboard: [cz-0.9.76]
You need to log in
before you can comment on or make changes to this bug.
Description
•