353528 - <select> fields with just one value shouldn't appear editable

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[timeless]

steps:
1. find a product that has only 1 version and only 1 tm, Websites works on bmo
2. find any bug in that product, e.g. bug 13146

compare: bgo 356938 <http://bugzilla.gnome.org/show_bug.cgi?id=356938>

expected results: consider not using any tags and instead just inline the value (in a span).

whether there should be a style (inset border or similar) is subject to negotiation.

note: this should be done globally for whatever generator we have so that you avoid the error that the gnome team created which can be seen in bgo 356938 <http://bugzilla.gnome.org/show_bug.cgi?id=356938> where target milestone has no select, but version does.

at this time, there's only one version (unspecified) and one target milestone (---).

Comment 1

[timeless]

Attachment: view of gnome bug

for reference, there are actually tms, but only special people can see them, so i misinterpretted why i got the read only field.

i'd rather assume my explanation than theres, as theirs is completely unintuitive.

Comment 2

[Reed Loden [:reed]]

Fixed on prodpatches for bmo upgrade. I'll attach a patch soon.

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v1

Add the "disabled" param to the <select> tag when there is only one option.

Comment 4

[Frédéric Buclin]

Comment on attachment 249658 [details] [diff] [review]
patch - v1

Disabled fields are not passed to the CGI script, and process_bug.cgi will complain that some parameters are missing.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v2

Oops, I didn't know disabled <select> elements were not passed back to the CGI script. Thanks for catching that! :)

Comment 6

[Frédéric Buclin]

Comment on attachment 249660 [details] [diff] [review]
patch - v2

r=LpSolit

Comment 7

[Reed Loden [:reed]]

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.96; previous revision: 1.95
done