353540 - Options, disable and uninstall button not available after "Find updates" without dismissing "No Updates Were Found" notification

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Jos Pletzers]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2

When you open the Add-ons manager window and hit the Find updates button it's impossible to disable or uninstall extentions before hitting the red cross in the top right corner.


Reproducible: Always

Steps to Reproduce:
1. open add-ons
2. click find updates

Actual Results:  
When you open the Add-ons manager window and hit the Find updates button it's impossible to disable or uninstall extentions before hitting the red cross in the top right corner.

Expected Results:  
Because it is only a message mentioning there are no updates availeble it should still be possible to disable or uninstall extentions. It should not be mandatory to close the popup window for only a service message

Comment 1

[Robert Strong (they/them - no direct email)]

We want to display the update status of the update check in the description which is why it is required to either dismiss the notification or change the view to get this functionality back since we don't want these options available during an update check which caused a bunch of other bugs in 1.5.0.x and below. For me this is wontfix but I am going to leave it open for now to think about it a bit

Comment 2

[Jackie Liu]

Perhaps we should have some sort of visual cue to the user?  Like dimming the disabled options?

Comment 3

[Robert Strong (they/them - no direct email)]

The behavior regressed recently... I'll take a look as soon as I am able to

Comment 4

[Jos Pletzers]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2)
> Gecko/20060821 Firefox/2.0b2
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2)
> Gecko/20060821 Firefox/2.0b2
> When you open the Add-ons manager window and hit the Find updates button it's
> impossible to disable or uninstall extentions before hitting the red cross in
> the top right corner.
> Reproducible: Always
> Steps to Reproduce:
> 1. open add-ons
> 2. click find updates
> Actual Results:  
> When you open the Add-ons manager window and hit the Find updates button it's
> impossible to disable or uninstall extentions before hitting the red cross in
> the top right corner.
> Expected Results:  
> Because it is only a message mentioning there are no updates availeble it
> should still be possible to disable or uninstall extentions. It should not be
> mandatory to close the popup window for only a service message


Just for the general understanding. After the update is finished it is still impossible to use the buttons. I agree it is unwanted to have the buttons availeble during the update but after the update has finished you should be able to use them.

Comment 5

[Jos Pletzers]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2)
> Gecko/20060821 Firefox/2.0b2
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2)
> Gecko/20060821 Firefox/2.0b2
> When you open the Add-ons manager window and hit the Find updates button it's
> impossible to disable or uninstall extentions before hitting the red cross in
> the top right corner.
> Reproducible: Always
> Steps to Reproduce:
> 1. open add-ons
> 2. click find updates
> Actual Results:  
> When you open the Add-ons manager window and hit the Find updates button it's
> impossible to disable or uninstall extentions before hitting the red cross in
> the top right corner.
> Expected Results:  
> Because it is only a message mentioning there are no updates availeble it
> should still be possible to disable or uninstall extentions. It should not be
> mandatory to close the popup window for only a service message


Just for the general understanding. After the update is finished it is still impossible to use the buttons. I agree it is unwanted to have the buttons availeble during the update but after the update has finished you should be able to use them.

Comment 6

[Michael Wu [:mwu]]

If no updates are found, it seems rather redundant to leave the same "no updates" message in every single extension on the list.. or are there situations in which an extension might have a different message? (due to bad update url?)

Comment 7

[Robert Strong (they/them - no direct email)]

there are other status messages besides no updates found

Comment 8

[Michael Wu [:mwu]]

I'm not convinced that this is the proper bug to fix the recent regression. This bug is about putting the options/disable/uninstall buttons back if we haven't found any updates, which is separate from the issue I want to fix. Opened bug 353918 to fix the regression.

Comment 9

[Mike Connor [:mconnor]]

Not going to block on this at this time, not clear what the right answer is, and its long past time to fix niggling little cases like this.

Comment 10

[Robert Strong (they/them - no direct email)]

bug 353918 restores the previous behavior of clearing the no updates found message, update status messages, and showing the buttons when switching views. I want to have the update status messages cleared before restoring the buttons since the complexity is significantly less than trying to display both at the same time. I think the fix for this could be to simply clear the no updates found message, update status messages, and showing the buttons when selecting an item in the list.

Comment 12

[Robert Strong (they/them - no direct email)]

beltzner, I think the normal use case is to be able to select options, disable, uninstall, etc. for add-ons after no updates are found though it would be a good thing to display the status message especially for the case where there is an error checking for updates. Perhaps a compromise where we dismiss the no updates found message and restore the buttons when a selection is made? The update status message would still be displayed when scrolling using the scrollbar so the update status message for add-ons that aren't in view can still be viewed. Not ideal but it should fix this for the normal use case.

Comment 13

[Robert Strong (they/them - no direct email)]

Attachment: patch ( implements comment #12 )

Comment 14

[Robert Strong (they/them - no direct email)]

Attachment: updated patch ( implements comment #12 )

Comment 15

[Dave Townsend [:mossop]]

Comment on attachment 279800 [details] [diff] [review]
updated patch ( implements comment #12 )

r=me, I'm assuming beltzner or something sounded off on this?

Comment 16

[Robert Strong (they/them - no direct email)]

I discussed this with him face to face

Comment 17

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.148; previous revision: 1.147
done

Comment 20

[Marcia Knous [:marcia]]

Litmus triage team: tomcat will handle litmus testcase.

Comment 21

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042506 Minefield/3.0pre.  

Litmus test added: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=5297