353579 - Turn on LayoutPerformanceTest for macosx trunk builds

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[T.R. Fullhart]

The LayoutPerformanceTest configuration option just needs to be uncommented in the tinder-config.pl.

Comment 1

[T.R. Fullhart]

Attachment: enable Tp tests for macosx firefox builds

preed has already reviewed the patch and accepted it, it needs to be applied to the trunk

Comment 2

[Robert Helmer [:rhelmer]]

Landed on trunk:

Checking in tinder-config.pl;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/macosx/tinder-config.pl,v  <--  tinder-config.pl
new revision: 1.4; previous revision: 1.3
done

Comment 3

[Robert Helmer [:rhelmer]]

A couple non-obvious problems:

* colo servers should us axolotl as pageserver not the default spider
* $GraphNameOverride should be set so that other trunk builds on this machine don't submit to the same graph.

More detail on that second point - the graph name submitted to build-graphs.mozilla.org is built from the hostname and the $BuildTag, in the case of trunk builds there is no BuildTag so graph results clobber eachother.

Comment 4

[T.R. Fullhart]

Attachment: patch to set GraphNameOverride in trunk version of firefox/macos/tinder-config.pl

This is a patch to be applied in the thunk tinderbox-configs to set the GraphNameOverride to 'xserve03.build.mozilla.org_Fx-Trunk' so, on the performance graph server, it can distiguish this build from the other builds on the box.

Comment 5

[Robert Helmer [:rhelmer]]

Comment on attachment 239538 [details] [diff] [review]
patch to set GraphNameOverride in trunk version of firefox/macos/tinder-config.pl

looks good, I'll land it right now.

Comment 6

[Robert Helmer [:rhelmer]]

Landed on trunk:

Checking in tinder-config.pl;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/macosx/tinder-config.pl,v  <--  tinder-config.pl
new revision: 1.6; previous revision: 1.5
done

Comment 7

[T.R. Fullhart]

Attachment: patch to set GraphNameOverride in FIREFOX_CAIRO_WORK version of firefox/macos/tinder-config.pl

This is a patch to be applied in the FIREFOX_CAIRO_WORK branch of tinderbox-configs to set the GraphNameOverride to 'xserve03.build.mozilla.org_Fx-Trunk-Cairo-Cocoa' and 'xserve03.build.mozilla.org_Fx-Trunk-Cairo-Cocoa' for the respective tinderboxes on that host. This is so, on the performance graph server, it can distiguish each build from the other builds on the box.

Comment 8

[Robert Helmer [:rhelmer]]

Landed on FIREFOX_CAIRO_WORK branch.

Checking in tinder-config.pl;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/macosx/tinder-config.pl,v  <--  tinder-config.pl
new revision: 1.3.2.7; previous revision: 1.3.2.6
done
Checking in tinder-config.pl-cocoa;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/macosx/Attic/tinder-config.pl-cocoa,v  <--  tinder-config.pl-cocoa
new revision: 1.1.2.7; previous revision: 1.1.2.6
done