Closed Bug 353602 Opened 18 years ago Closed 12 years ago

js_UnlockGCThingRT always does a hashtable lookup

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: bzbarsky, Unassigned)

Details

See bug 311582 comment 10.  Basically if we lock a non-deep thing only once, we just set the GCF_LOCK flag in its flags.  But when unlocking we always check rt->gcLocksHash, since we can't tell from the simple presence of the GCF_LOCK flag whether the lock count is one or more...

Brendan says we can somehow avoid this hashtable lookup.
This is almost never called, perf can't really matter.  (We should really just remove the API)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.