js_UnlockGCThingRT always does a hashtable lookup

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
RESOLVED WONTFIX
12 years ago
6 years ago

People

(Reporter: bz, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

See bug 311582 comment 10.  Basically if we lock a non-deep thing only once, we just set the GCF_LOCK flag in its flags.  But when unlocking we always check rt->gcLocksHash, since we can't tell from the simple presence of the GCF_LOCK flag whether the lock count is one or more...

Brendan says we can somehow avoid this hashtable lookup.

Comment 1

6 years ago
This is almost never called, perf can't really matter.  (We should really just remove the API)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.