353655 - --enable-timeline doesn't build

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Axel Hecht [:Pike]]

nsITimelineService.idl defines a set of functions to actually implement the macros it exposes, and those function are declared as 

extern "C" NS_COM nsresult

and nsTimelineService.cpp uses 

PR_IMPLEMENT(nsresult)

to implement that. That somehow doesn't make our build happy in some config. I use a xulrunner opt dynamic build, but didn't disable libxul. Not sure if that would change something, but I guess that in our new linking world, probably both sides in the timeline service are wrong.

Benjamin?

Comment 1

[Doug Turner (:dougt)]

what is the error log look like?

Comment 2

[Axel Hecht [:Pike]]

Attachment: full buildlog

c:/Sources/full/mozilla/xpcom/ds/nsTimelineService.cpp(332) : error C2375: 'NS_TimelineForceMark' : redefinition; different linkage
        ../../dist/include/xpcom\nsITimelineService.h(254) : see declaration of 'NS_TimelineForceMark'

is the first, full build log attached.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Proposed patch

Use PR_EXTERN in nsITimelineService.idl.

I am not sure that use of PR_EXTERN in idl is good manner of Mozilla.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

On WinCE build, there are the same error in comment #1.

And on Linux with gcc-4.3.3, there are some warnings like the following:

/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp: In function 'nsresult NS_TimelineForceMark(const char*, ...)':
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:331: warning: 'nsresult NS_TimelineForceMark(const char*, ...)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:254: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp: In function 'nsresult NS_TimelineMark(const char*, ...)':
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:340: warning: 'nsresult NS_TimelineMark(const char*, ...)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:253: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp: In function 'nsresult NS_TimelineStartTimer(const char*)':
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:360: warning: 'nsresult NS_TimelineStartTimer(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:255: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:387: warning: 'nsresult NS_TimelineStopTimer(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:256: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:414: warning: 'nsresult NS_TimelineMarkTimer(const char*, const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:258: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:447: warning: 'nsresult NS_TimelineResetTimer(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:257: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:467: warning: 'nsresult NS_TimelineIndent()': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:259: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:479: warning: 'nsresult NS_TimelineOutdent()': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:260: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:491: warning: 'nsresult NS_TimelineEnter(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:261: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:500: warning: 'nsresult NS_TimelineLeave(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:262: warning: conflicts with previous declaration here

Comment 5

[Hiroyuki Ikezoe (:hiro)]

(In reply to comment #4)
> On WinCE build, there are the same error in comment #1.

This meant comment #2, of course.

Comment 6

[Benjamin Smedberg]

Comment on attachment 373022 [details] [diff] [review]
Proposed patch

I think the timeline service is a bad API that should be removed.

We might want to add a simple timeline service back, but it should be always on and we should come up with useful marking points rather than letting it rot all the time and having hit and miss timeline marks based on who's using it right now.

Comment 7

[Ed Morley [:emorley]]

nsITimelineService was removed by bug 579571, so this is wontfix.