Closed Bug 353679 Opened 18 years ago Closed 18 years ago

extra space in info text in updater (between text and ellipsis) ex: "a few moments ..."

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: moco, Assigned: moco)

References

Details

Attachments

(1 file)

patch (just remove that space)
557 bytes, patch
reed
: review+
Details | Diff | Splinter Review 
extra space in info text in updater (between text and ellipsis)  ex:  "a few
moments ..." 

This comes from bug #305390

for firefox, the string is in:

/browser/locales/en-US/updater/updater.ini, line 4 -- Info=Firefox is
installing your updates and will start in a few moments ...

I don't think we want the space between moments and ..., right?

assigning to beltzner for string ui-r.

note, tbird has the same problem, see bug #353590

perhaps this fix (just the removal of whitespace) could ride along in FF2 RC2, if there is one?
Flags: blocking-firefox2?
Whiteboard: [hoping for a ride along, but this may have l10 impact, but not sure]
Whiteboard: [hoping for a ride along, but this may have l10 impact, but not sure] → [hoping for a FF2 RC2 ride along, but this may have l10 impact, but not sure]
OS: Mac OS X 10.3 → All
Hardware: PC → All
Assignee: beltzner → sspitzer
Whiteboard: [hoping for a FF2 RC2 ride along, but this may have l10 impact, but not sure] → [hoping for [rc ridealong], but this may have l10 impact, but not sure]
totally minor, not worth the (admittedly minimal) churn.
Flags: blocking-firefox2? → blocking-firefox2-
I'll just go fix this for trunk only.

axel, if I'm just removing a space, do I need to change the entity name?
Whiteboard: [hoping for [rc ridealong], but this may have l10 impact, but not sure]
The space before the ellipsis is language dependent, thus this doesn't have l10n impact, but is the same thing as a typo.
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 3 alpha1
Comment on attachment 239534 [details] [diff] [review]
patch (just remove that space)

reed / mike, I'll take either.
Attachment #239534 - Flags: review?(reed)
Comment on attachment 239534 [details] [diff] [review]
patch (just remove that space)

r=reed, though I'd still love to see bug 324758 fixed sometime. :)
Attachment #239534 - Flags: review?(reed)
Attachment #239534 - Flags: review?(beltzner)
Attachment #239534 - Flags: review+
fixed, thanks reed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: