353728 - Klocwork 89175 null ptr deref in prdtoa.c

Status: RESOLVED WONTFIX

(NSPR :: NSPR, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

Klocwork ID 89175
File     pr/src/misc/prdtoa.c 
function Balloc

Pointer 'rv' returned from call to function 'malloc' at line 604 may be NULL 
and will be dereferenced at line 606.

Comment 1

[Wan-Teh Chang]

It's easy to fix this bug in Balloc, but Balloc and
the functions that call it can also return NULL.  None
of the callers of these functions check the functions'
return values for NULL.

So a better strategy is to ensure that MALLOC doesn't
need to be called.  You can search for Omit_Private_Memory
in the file.  It seems that by making the file single threaded,
using a large enough PRIVATE_MEM value, and limiting the
maximum length of a string to be converted, MALLOC calls
can be avoided.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

No activity for 12 years, I think we can close it...