353801 - See error when dragging the searchbar to the customize window

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Ria Klaassen (not reading all bugmail)]

When I drag the searchbar to the customize window I see:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/search/search.xml ::  :: line 110"  data: no]

And when I drag it back:

Error: document.getElementById(toolbarMenuElt.childNodes[i].getAttribute("observes")) has no properties
Source File: chrome://browser/content/browser.js
Line: 1863

Comment 1

[Ria Klaassen (not reading all bugmail)]

The first error has this regression range:
1.8.1b2_2006083013 - 1.8.1b2_2006083021.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Ah, yes, this is a regression from bug 338378. The constructor (which calls addObserver) is only called conditionally, but the destructor (which calls removeObserver) is called unconditionally.

I'm pretty sure that the exception is harmless, unless an XBL destructor throwing causes leaks. The constructor didn't do anything anyways.

Comment 3

[Ria Klaassen (not reading all bugmail)]

The second error is trunk-only:
Regression between 1.9a1_2006072411 and 1.9a1_2006072509. So they won't be related I think.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

The second error is bug 346757.