353981 - Problems with globalAlpha being ignored sometimes

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Dan Mills [:thunder]]

This code breaks:

var x1 = Math.round((this.endTime - xoffs) * xscale);
beginPath();
moveTo(x0-0.5, v+0.5);
lineTo(x1+0.5, v+0.5);
strokeStyle = colorToRgbString(this.dataSets[i].color);
globalAlpha = 0.2;
lineWidth = 5.0;
stroke();
globalAlpha = 1.0;
lineWidth = 1.0;
stroke();

But doing a save and restore instead works.

Comment 1

[Philip Taylor]

Attachment: test case

Added clearer test case. Confirmed in current trunk build on Windows.

Comment 2

[Philip Taylor]

Attachment: patch

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Thanks for the patch!  Though, could you set a review request on me when you file patches?  Otherwise I often miss them.

Comment 4

[Mike Schroepfer]

Is this a regression in 1.9?

Comment 5

[Reed Loden [:reed]]

Checking in content/canvas/src/nsCanvasRenderingContext2D.cpp;
/cvsroot/mozilla/content/canvas/src/nsCanvasRenderingContext2D.cpp,v  <--  nsCanvasRenderingContext2D.cpp
new revision: 1.107; previous revision: 1.106
done