354092 - Mutation events should be able to use strings for attr values

Status: RESOLVED INACTIVE

(Core :: DOM: Events, defect, P5)

Description

[Boris Zbarsky [:bzbarsky]]

Except in XUL (where attr values are commonly atomized), atomizing atom values for mutation events is kinda a waste of time.

Frankly, I think mutation events should just have an nsAttrValue* or something; certainly for the old value.  Probably need to fix bug 314286 first, though.  Then we can think about where to go here.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Honestly, is this a big deal either way? I Agree that atomizing seems a bit unneccesary, ideally we should IMHO do what simplest as I doubt that performance matters much.

That said, nsAttrValue* seems like a good idea.

Comment 2

[Boris Zbarsky [:bzbarsky]]

It shows up in some profiles....  Not huge, but a few percent, just like every other piece of "could be faster" code in our engine, most of the time.  ;)

I don't think this is critical, by any means.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.