354166 - Add --dry-run and download-dependency support to patcher2

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P3)

Description

[J. Paul Reed [:preed]]

This is a tracking bug/dumping ground for various patcher2 improvements that I never got around to doing before putting it in the public repo.

The first patch that'll go here is a patch for adding the ability to specify different appv/extv values for a release.

Other things that will probably eventually find their way to this bug:

-- --dry-run support
-- Download dependency support (so you don't have to explicitly run --download first)

Comment 1

[J. Paul Reed [:preed]]

Attachment: appv != extv support

Comment 2

[J. Paul Reed [:preed]]

Attachment: Add support for a self-defined CVSROOT

Comment 3

[J. Paul Reed [:preed]]

Reassigning bugs I'm not actively working on back into the triage pool.

Comment 4

[J. Paul Reed [:preed]]

Attachment: Cache HashFile() calls

This isn't really either of the features in the bug summary, but this bug used to be "various patcher2 improvements," so I'll put it here; this bug basically caches calls to MozUtil::HashFile(); this is a pretty large perf win for patcher2, because it once the partial and complete patches are hashed once for the partial/complete snippets, we generate thousands of other snippets that can use that info:

Pre-cache:

real    6m23.387s
user    2m14.288s
sys     0m34.618s

Post-cache:

real    1m20.793s
user    0m15.677s
sys     0m6.452s

I've generated 2.0.0.2 -> 2.0.0.3 snippets (just what I had lying around on my dev box), with and w/o the patch, and diffed the snippets; they look good (i.e. not different from each other).

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 274678 [details] [diff] [review]
Cache HashFile() calls

nice win! Just one paranoid /perl-novice thought, are there / in the $file's, and does that cause any problems when used as a hash key.

Comment 6

[J. Paul Reed [:preed]]

Cache HashFile() calls patch  landed:

Checking in MozAUSLib.pm;
/cvsroot/mozilla/tools/patcher/MozAUSLib.pm,v  <--  MozAUSLib.pm
new revision: 1.6; previous revision: 1.5
done
Checking in patcher2.pl;
/cvsroot/mozilla/tools/patcher/patcher2.pl,v  <--  patcher2.pl
new revision: 1.22; previous revision: 1.21
done

Comment 7

[Robert Strong (they/them - no direct email)]

Since there hasn't been any activity and there has been a checkin associated with this I am resolving -> fixed.