354357 - --enable-pango breaks the build process

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[rbs]

In the course of investigating bug 321994, I had to make a build with --enable-pango, but this broke the build process. When it happened, I had to go to
the directory (the OBJ/gfx/src/gtk), copy-paste the failing command and add
-lpangoft2-1.0, before re-doing another make -f client.mk build_all.

Comment 1

[Adam Guthrie]

What was the actual error?

Comment 2

[rbs]

gmake[1]: Entering directory `/home/rbs/mozilla/tip/objd/firefox/gfx/src/gtk'
nsFontMetricsPango.cpp
c++ -o nsFontMetricsPango.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6.10-1\" -DOSARCH=\"Linux\" -DBUILD_ID=0000000000 -DUSE_POSTSCRIPT -I../.. -I/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/. -I/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/.. -I/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/../shared -I/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/../x11shared -I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/freetype2/config    -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/widget -I../../../dist/include/view -I../../../dist/include/util -I../../../dist/include/pref -I../../../dist/include/uconv -I../../../dist/include/unicharutil -I../../../dist/include/locale -I../../../dist/include/necko -I../../../dist/include   -I../../../dist/include/gfx -I../../../dist/include/nspr    -I../../../dist/sdk/include -I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_rbs -DTRACING -g -fno-inline  -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsFontMetricsPango.pp /home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp
In file included from /home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp:50:
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/../nsRenderingContextImpl.h:199: warning: `virtual nsresult nsRenderingContextImpl::DrawString(const char*, PRUint32, nscoord, nscoord, const nscoord*)' was hidden
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsRenderingContextGTK.h:162: warning:   by `virtual nsresult nsRenderingContextGTK::DrawString(const nsString&, nscoord, nscoord, PRInt32, const nscoord*)'
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/../nsRenderingContextImpl.h:203: warning: `virtual nsresult nsRenderingContextImpl::DrawString(const PRUnichar*, PRUint32, nscoord, nscoord, PRInt32, const nscoord*)' was hidden
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsRenderingContextGTK.h:162: warning:   by `virtual nsresult nsRenderingContextGTK::DrawString(const nsString&, nscoord, nscoord, PRInt32, const nscoord*)'
rm -f libgfx_gtk.so
c++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_rbs -DTRACING -g -fno-inline  -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -fPIC -shared -Wl,-z,defs -Wl,-h,libgfx_gtk.so -o libgfx_gtk.so  nsDeviceContextGTK.o nsDrawingSurfaceGTK.o nsGfxFactoryGTK.o nsGraphicsStateGTK.o nsImageGTK.o nsGCCache.o nsRenderingContextGTK.o nsFontMetricsUtils.o nsFontMetricsXft.o nsFontMetricsPango.o mozilla-decoder.o nsRegionGTK2.o    -lpthread          ../shared/libgfxshared_s.a  -Wl,-Bsymbolic -lfreetype -lz -L../../../dist/bin -L../../../dist/lib -lgkgfx  -L../../../dist/bin -lmozjs ../../../dist/lib/libunicharutil_s.a -L../../../dist/bin -lxpcom -lxpcom_core  -L../../../dist/bin -L../../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl  -lpangoxft-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0   -L/usr/X11R6/lib -lX11   -L/usr/X11R6/lib -lXft -lX11 -lfreetype -lXrender -lfontconfig   -lgtk-x11-2.0 -latk-1.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lm -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgmodule-2.0 -ldl -lgobject-2.0 -lglib-2.0   -lgfxpsshar -ldl -lm
nsFontMetricsPango.o(.text+0xf4e): In function `nsFontMetricsPango::CacheFontMetrics()':
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp:276: undefined reference to `pango_fc_font_get_type'
nsFontMetricsPango.o(.text+0xf80):/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp:282: undefined reference to `pango_fc_font_lock_face'
nsFontMetricsPango.o(.text+0x12a7):/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp:351: undefined reference to `pango_fc_font_has_char'
nsFontMetricsPango.o(.text+0x12bb):/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp:353: undefined reference to `pango_fc_font_get_glyph'
nsFontMetricsPango.o(.text+0x18c6):/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp:414: undefined reference to `pango_fc_font_unlock_face'
mozilla-decoder.o(.text+0x6a): In function `mozilla_decoder_get_type':
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:57: undefined reference to `pango_fc_decoder_get_type'
mozilla-decoder.o(.text+0xbf): In function `mozilla_decoder_class_init':
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:103: undefined reference to `pango_fc_decoder_get_type'
mozilla-decoder.o(.text+0x192): In function `mozilla_decoders_init':
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:151: undefined reference to `pango_fc_font_map_get_type'
mozilla-decoder.o(.text+0x97d):/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:217: undefined reference to `pango_fc_font_map_get_type'
mozilla-decoder.o(.text+0x992):/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:217: undefined reference to `pango_fc_font_map_add_decoder_find_func'
mozilla-decoder.o(.text+0xd26): In function `mozilla_decoder_get_glyph':
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:305: undefined reference to `pango_fc_font_lock_face'
mozilla-decoder.o(.text+0xdf8):/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:342: undefined reference to `pango_fc_font_unlock_face'
mozilla-decoder.o(.text+0xfb6): In function `mozilla_find_decoder':
/home/rbs/mozilla/tip/mozilla/gfx/src/gtk/mozilla-decoder.cpp:380: undefined reference to `pango_fc_decoder_get_type'
collect2: ld returned 1 exit status
gmake[1]: *** [libgfx_gtk.so] Error 1
gmake[1]: Leaving directory `/home/rbs/mozilla/tip/objd/firefox/gfx/src/gtk'
make: *** [default] Error 2

Comment 3

[Boris Zbarsky [:bzbarsky]]

Shouldn't we just remove this option on trunk, given that cairo uses pango?

Comment 4

[Benjamin Smedberg]

/me shrugs and looks at vlad

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

If this is trunk, then that's not a supported config (gtk1/gtk2 gfx).  We do need to remove a bunch of these options from the trunk, but we can't yet, as we have tinderboxes still building unsupported configs.