Crash [@ nsXULElement::HideWindowChrome] setting hidechrome to true

VERIFIED FIXED

Status

()

defect
--
critical
VERIFIED FIXED
13 years ago
8 years ago

People

(Reporter: jruderman, Assigned: smaug)

Tracking

(Blocks 1 bug, {crash, testcase})

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments)

Reporter

Description

13 years ago
 
Reporter

Comment 1

13 years ago
Posted file testcase
Crashes on WinXP as well.
OS: Mac OS X 10.4 → All
Hardware: Macintosh → All
Assignee

Comment 3

13 years ago
The needed fix in this case is just (doc->GetRootContent() != this), 
but I think it makes sense to add also that NS_ENSURE_STATE.

HideWindowChrome() is used only with <window> and IMO we can assume that HideWindowChrome works only when <window> is used as 
a root element.
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #246381 - Flags: superreview?(neil)
Attachment #246381 - Flags: review?(enndeakin)
Comment on attachment 246381 [details] [diff] [review]
proposed patch

[I wonder whether it's worth adding the tag check here or moving the doc check into the caller...]
Attachment #246381 - Flags: superreview?(neil) → superreview+

Updated

13 years ago
Attachment #246381 - Flags: review?(enndeakin) → review+
Assignee

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified FIXED using build 2006-11-24-10 of SeaMonkey trunk under Windows XP using https://bugzilla.mozilla.org/attachment.cgi?id=240399&action=view as the testcase; no crash.
Status: RESOLVED → VERIFIED
Reporter

Comment 6

12 years ago
Crashtest checked in.
Flags: in-testsuite+

Updated

11 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
Crash Signature: [@ nsXULElement::HideWindowChrome]
You need to log in before you can comment on or make changes to this bug.