Closed
Bug 354634
Opened 18 years ago
Closed 18 years ago
Failed to load XPCOM component: globalstore.js
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: moco, Assigned: tony)
Details
(Keywords: verified1.8.1.2)
Attachments
(2 files)
714 bytes,
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
937 bytes,
patch
|
jay
:
approval1.8.1.2+
|
Details | Diff | Splinter Review |
Failed to load XPCOM component: /Users/sspitzer/Desktop/trunk-no-places/debug-build/dist/MinefieldDebug.app/Contents/MacOS/components/globalstore.js this is with my trunk, debug mac build: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a1) Gecko/20060927 Minefield/3.0a1 see also http://lxr.mozilla.org/seamonkey/search?string=globalstore.js tony, any ideas?
Assignee | ||
Comment 1•18 years ago
|
||
Hmm, that's weird. I'm not sure how globalstore.js got into your components directory. It should be pre-processed into a single component (nsSafeBrowsing.js) with the other files in the browser/components/safebrowsing/content/ directory. Looking into it . . .
Assignee | ||
Comment 2•18 years ago
|
||
Looks like it was accidentally added by bug 344897. Also exists on branch.
Assignee: nobody → tony
Status: NEW → ASSIGNED
Assignee | ||
Updated•18 years ago
|
Attachment #240415 -
Flags: review?(sspitzer)
Reporter | ||
Comment 3•18 years ago
|
||
Comment on attachment 240415 [details] [diff] [review] remove globalstore.js from components r=sspitzer, makes sense to me. thanks for the quick fix, tony.
Attachment #240415 -
Flags: review?(sspitzer) → review+
Assignee | ||
Comment 4•18 years ago
|
||
Checking in Makefile.in; /cvsroot/mozilla/browser/components/safebrowsing/Makefile.in,v <-- Makefile.in new revision: 1.5; previous revision: 1.4 On trunk.
Comment 5•18 years ago
|
||
is this still broken on branch?
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking1.8.1.2?
Resolution: --- → FIXED
Comment 6•18 years ago
|
||
is this still broken on branch?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•18 years ago
|
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•18 years ago
|
||
from lxr, it looks like this is still an issue on the branch: http://lxr.mozilla.org/mozilla1.8/source/browser/components/safebrowsing/Makefile.in#58 but, I haven't confirmed that.
Assignee | ||
Comment 8•18 years ago
|
||
Yeah, I never committed on branch.
Updated•18 years ago
|
Flags: blocking1.8.1.2? → blocking1.8.1.2-
Comment 9•18 years ago
|
||
Tony: Not blocking, but will gladly accept any patch approvals for the 1.8 branch. ;-)
Comment 11•18 years ago
|
||
Comment on attachment 249316 [details] [diff] [review] patch for branch Approved for 1.8 branch, a=jay for drivers.
Attachment #249316 -
Flags: approval1.8.1.2? → approval1.8.1.2+
Assignee | ||
Comment 12•18 years ago
|
||
on branch Checking in browser/components/safebrowsing/Makefile.in; /cvsroot/mozilla/browser/components/safebrowsing/Makefile.in,v <-- Makefile.in new revision: 1.1.2.4; previous revision: 1.1.2.3 done
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•