Closed Bug 354645 Opened 13 years ago Closed 13 years ago
Crash [@ ns
Box Frame::Append Frames] removing <xul:tabs> during onselect
Loading this testcase makes Firefox (debug) crash with 0xdddddddc nsBoxFrame::AppendFrames nsFrameManager::AppendFrames nsCSSFrameConstructor::AppendFrames ... Nightlies crash too, but with a slightly different stack trace.
I can reproduce on the Firefox 2 branch, too, so nominating for blocking1.8.1.
Too late for this type of thing, should fix for 184.108.40.206
Flags: blocking1.8.1? → blocking1.8.1-
Usual problem -- the XBL constructor is run while the frame tree is not yet done being constructed, it does some stuff, said stuff triggers a select event firing, which removes the node from the tree (and destroys its frames). Then we unwind and attempt to insert said deleted frames into the tree, dereference 0xdddddddd (in debug builds, or random memory in opt builds), and crash.
Depends on: 267833
Assignee: nobody → general
Component: XP Toolkit/Widgets: XUL → XBL
QA Contact: xptoolkit.xul → ian
Does this happen in 1.8.0.x as well?
Flags: blocking220.127.116.11? → blocking18.104.22.168+
Jonas: Can you take a look at this?
Assignee: general → bugmail
By bzs description I don't think we should try to fix this one particular crash since there's a bigger general issue that can cause many different types of crashes. I.e. that we run XBL ctors at unsafe times. I'll try to look in to that issue as i'm whacking XBL and nsCSSFrameCtor interaction in general.
does the "whacking XBL and nsCSSFrameCtor interaction in general" work have bugs or a spec to help tracking the work and its possible impact on fixing this one? be good to add those links here.
Marking blocking for now. Hopefully the fix for 267833 will fix this one.
Flags: blocking1.9? → blocking1.9+
Doesn't crash now (probably due to the patch in bug 267833).
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Moving out to 22.214.171.124 following bug 267833
Flags: blocking126.96.36.199+ → blocking188.8.131.52+
Whiteboard: [sg:critical] → [sg:critical] fixed by 267833
Flags: blocking184.108.40.206+ → blocking220.127.116.11?
verified fixed 18.104.22.168 using : Mozilla/5.0 (Macintosh; U; Intel Mac OS X; ja-JP-mac; rv:22.214.171.124) Gecko/2007100816 Firefox/126.96.36.199 - no crash on testcase - adding verified keyword
Flags: blocking188.8.131.52? → blocking184.108.40.206?
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2007123104 Minefield/3.0b3pre and the testcase from this bug - no crash on testcase -> Verified fixed
Status: RESOLVED → VERIFIED
Crash Signature: [@ nsBoxFrame::AppendFrames]
You need to log in before you can comment on or make changes to this bug.