command keys broken when Composer is active

VERIFIED WORKSFORME

Status

()

Core
Event Handling
P1
normal
VERIFIED WORKSFORME
18 years ago
18 years ago

People

(Reporter: Joe Francis, Assigned: Brade)

Tracking

Trunk
PowerPC
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
bring up composer.  try to use any of the command-key equivalents.  they dont 
work.  they appear to work fine with a browser window frontmost.

Comment 1

18 years ago
I'm gonna start this one off with saari, he knows a lot more about command-key's 
than me.
Assignee: joki → saari

Comment 2

18 years ago
When did this happen?
Status: NEW → ASSIGNED
Target Milestone: --- → M16

Updated

18 years ago
Priority: P3 → P1

Comment 3

18 years ago
They work fine for me on today's Mac build. I ran just editor. The only ones that 
didn't work were underline, bold and italic. All the others worked.

Comment 4

18 years ago
Okay, if I play around with using bold, italic, and underline from the menu and 
from the keybinding in various sequences, I can get the commands to both work and 
fail, regardless of if you use a keybinding or a menu.

When the commands fail, I get this output to the console:
JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code: 
0x80004005 (NS_ERROR_FAILURE) [nsIController.doCommand]"  nsresult: "0x80004005 
(NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/
globalOverlay.js :: goDoCommand :: line 231"  data: no]

Updated

18 years ago
Assignee: saari → jfrancis
Status: ASSIGNED → NEW
Target Milestone: M16 → ---

Comment 5

18 years ago
After looking into this further, it is obviously getting into the editor 
controller just fine, but the commands are failing (or succeeding) deep in editor 
code, so I'm tossing this back.

Comment 6

18 years ago
assigning to brade for review
Assignee: jfrancis → brade
Target Milestone: --- → M16
(Assignee)

Comment 7

18 years ago
Chris Saari thinks that this may be due to a css omission in Composer's 
toolbars...

Comment 8

18 years ago
Eh? errors from goDoCommand() are errors returned from the execution of the 
command, most likely. This is actually an old bug, which should probably be 
WORKSFORME now. If we are getting errors from command execution, that's something 
different.
(Assignee)

Comment 9

18 years ago
resolving as worksforme per comments by sfraser
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WORKSFORME

Comment 10

18 years ago
Marking bug as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.