354726 - when moving a message between folders, keywords (tags and junk status) are lost

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Asa Dotzler [:asa]]

I've just migrated to the new mail server infrastructure at MoCo and updated Thunderbird to the latest nightly Tbird 2 build. 

When I move a message (or it's automatically moved) from one folder to another folder, the junk status and tags are lost. If the server doesn't support it, we should do the move ourselves to preserve the keywords.

Comment 1

[David :Bienvenu]

This works fine for me with the new MoCo server, because it actually handles it on the server, so we don't have to. 

What doesn't work is migrating keywords from the old server to the new server, because the old server didn't support keywords, so there was nothing to migrate.

Comment 2

[David :Bienvenu]

Argh, I think the MoCo server has an unfortunate behavior - when we store a keyword like Work1, it turns it into WORK1. We treat user-defined keywords as case sensitive, though we treat the reserved keywords case-insensitively. Maybe we have to ignore the case of user-defined keywords but that scares me with mod-utf7 strings.

Comment 3

[David :Bienvenu]

Attachment: this should fix the tags problem

This will fix the tags problem, for newly created tags - but I'm really not happy about it and I'd like to push back a little on the MoCo server... 

Asa, you can fix your tags by editing your prefs.js and converting all your keys to upper case.  So, for example, for the tag "Work1", you want to change the pref names to *.WORK1, like this:

user_pref("mailnews.tags.WORK1.color", "");
user_pref("mailnews.tags.WORK1.tag", "Work1");

Comment 4

[David :Bienvenu]

Attachment: fix for junk/non junk keyword handling

this should fix the losing of the junk/non junk keywords. I'm still thinking about the other keyword handling - my other patch fixes the problem for the MoCo server, but we really want to do case-insensitive compares instead of just always using upper case keys, because some server might arbitrarily decide to lower case all the keywords it returns...

Comment 5

[David :Bienvenu]

Attachment: normalize all keys to lower case

upgrade all tag prefs so that the key is lower case, and make all queries lower case the key in the pref name before loading the pref.

Comment 6

[Scott MacGregor]

Comment on attachment 241098 [details] [diff] [review]
normalize all keys to lower case

I don't think this is the right patch attachment...

Comment 7

[David :Bienvenu]

Attachment: oops, right tree, wrong directory

Comment 8

[David :Bienvenu]

fixed on trunk and branch.

Comment 9

[Karsten Düsterloh]

The dropped error code of GetColorForKey here caused bug 368370.