354804 - remove unnecessary code from help.css

Status: NEW

(SeaMonkey :: Help Viewer, defect)

Description

[dror3go]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0

Button home & button print can't be disabled in Help -> Help Contents.
Therefore, we can remove everything that deals with this issues.

This code:

#help-home-button:not([disabled="true"]):hover { 
  -moz-image-region: rect(24px 72px 48px 48px); 
}
#help-home-button[disabled="true"] { 
  -moz-image-region: rect(48px 72px 72px 48px); 
}
#help-home-button:not([disabled="true"]):hover:active { 
  -moz-image-region: rect(72px 72px 96px 48px); 
}

#help-print-button:not([disabled="true"]):hover { 
  -moz-image-region: rect(24px 96px 48px 72px); 
}
#help-print-button[disabled="true"] { 
  -moz-image-region: rect(48px 96px 72px 72px); 
}
#help-print-button:not([disabled="true"]):hover:active { 
  -moz-image-region: rect(72px 96px 96px 72px); 
}

Can be converted to this:

#help-home-button:hover { 
  -moz-image-region: rect(24px 72px 48px 48px); 
}
#help-home-button:hover:active { 
  -moz-image-region: rect(72px 72px 96px 48px); 
}

#help-print-button:hover { 
  -moz-image-region: rect(24px 96px 48px 72px); 
}
#help-print-button:hover:active { 
  -moz-image-region: rect(72px 96px 96px 72px); 
}

Reproducible: Always

Comment 1

[:Gavin Sharp [email: [e-mail]]]

If you're going to do that, you should also remove the disabled states from help's Toolbar.png.

Comment 2

[dror3go]

I don't see why help/Toolbar.png is necessary - why not simply using browser/Toolbar.png instead?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Because that would create a /toolkit dependency on a /browser file.

Comment 4

[dror3go]

Attachment: new help.css

Can someone please remove the disabled states from help's Toolbar.png?