If an xpicleanup.dat file is present, Seamonkey 1.1a won't start. Attempting to run xpicleanup manually yields a crash: Killed by SIGSEGV pid=0x0084 ppid=0x0044 tid=0x0001 slot=0x006a pri=0x0200 mc=0x0001 D:\OS2APPS\MOZILLA\BIN\XPICLEANUP.EXE XPICLEAN 0:0000046e cs:eip=005b:0001046e ss:esp=0053:0011fde0 ebp=0011ffa0 ds=0053 es=0053 fs=150b gs=0000 efl=00012246 eax=00000000 ebx=0011ffa8 ecx=00000000 edx=0011ffc5 edi=0011fe08 esi=00000000 Process dumping was disabled, use DUMPPROC / PROCDUMP to enable it. There is speculation that there is a bug in the libc06 spawn/exec*() implementation. Another user reports that it works on trunk build from 2 days ago; not sure if that is a libc05 or lib06 build. Setting initial state to unconfirmed, as I have yet to see anyone else confirm that they see this.
Just for the record, it is a libc06 trunk build that I was referring to.
Yes, the same crash happens here, but that doesn't look like it can be caused by the libc06 implementation of spawn/exec*(). From the address it seems to crash in PerformScheduledTasks().
It does not crash when called as ".\xpicleanup" instead of just "xpicleanup". The logic to strip off the path in InstallCleanupOS2.cpp is flawed. But I think the real problem is that xpicleanup does not get called correctly from SeaMonkey, and not that it crashes when called in a wrong way.
Created attachment 240718 [details] [diff] [review] Correct crash when backslash is missing This adds another safeguard to xpicleanup in case there is no backslash in the path. It includes the same change in the Windows code, but as I don't have Windows I cannot test and don't know if it is even necessary.
Just for the record, the same crash occurs on trunk (and probably on Windows), too, and it has nothing to do with PerformScheduledTasks().
Comment on attachment 240718 [details] [diff] [review] Correct crash when backslash is missing r=mkaply for the OS/2 part only
Comment on attachment 240718 [details] [diff] [review] Correct crash when backslash is missing sr=dveditz (and r= on the windows patch)
Thanks for the reviews. Fixed on trunk.
Comment on attachment 240718 [details] [diff] [review] Correct crash when backslash is missing I think we should finally get this into branch, too. At least for OS/2 this is an annoying problem and the fix hasn't caused a problem in the last 10 months.
Comment on attachment 240718 [details] [diff] [review] Correct crash when backslash is missing approved for 184.108.40.206, a=dveditz for release-drivers
Verified as fixed on OS/2 with the SeaMonkey 2007-08-31 branch nightly. Leaving as fixed220.127.116.11 for Windows verification.
Peter: Can you verify this Bug also for 18.104.22.168, since i don`t have a OS/2 System ?
That's what I said in comment 11. :-) Assuming that Carsten's comment means that verification was done on Windows, I now mark it verified.