354885 - Bad HTML comments parsing in contents.rdf

Status: RESOLVED INVALID

(SeaMonkey :: Installer, defect)

Description

[servinfo]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.6) Gecko/20060728 SUSE/1.0.4-0.1 SeaMonkey/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.6) Gecko/20060728 SUSE/1.0.4-0.1 SeaMonkey/1.0.4

My extension stub (just added button without any function) stop installing after I put some "pretty comment" lines into code. I start to take back the comments until I found the problem in contents.rdf.

There is no instalation problem with normal comments like this <!-- comment --> in contents.rdf.

But if the file contents.rdf contains comments with multiple '-' characters, then i fails with message 'Chrome registration failed'. Examples of bad comments:

<!-------- comment -->
<!-- comment -- comment -->
<!-- comment - comment - comment -->

I strip the extension to two several lines' files (install.js, contents.rdf) and the problem remains.

I'm very sorry but I have poor connection to internet and I can't download the lattest seamonkey version, but I can test any other case, that will be interesting for you.

I start with bigger installation script that checked return values, that I removed in sent example code, but for your info I attach part of install. log.

install failed:


     buk (version 0.003)
     ---

     ** initInstall: 0
     ** chrome_dir = /home/kit/.mozilla/Default User3/zlyw021b.slt/chrome/
     ** folder = /home/kit/.mozilla/Default User3/zlyw021b.slt/chrome/buk/
     ** addFile() for JAR returned: 0
     ** regChrome (skin) returned: 0
     [1/2]      Installing: /home/kit/.mozilla/Default User3/zlyw021b.slt/chrome/buk/buk.jar
     [2/2]      Register Skin: jar:file:///home/kit/.mozilla/Default%20User3/zlyw021b.slt/chrome/buk
     ** InstallSkin() failed. - nsresult code: 0x80004005
     ** InstallLocale() failed. - nsresult code: 0x80004005
     ** InstallPackage() failed. - nsresult code: 0x80004005
     ** Failed to register chrome. - nsresult code: 0x80004005

     Install **FAILED** with error -239  --  2006-09-29 22:27:36


correct install:

-------------------------------------------------------------------------------
file:///home/kit/bordel/xul/buk.xpi  --  2006-09-29 22:29:41
-------------------------------------------------------------------------------

     buk (version 0.003)
     ---

     ** initInstall: 0
     ** chrome_dir = /home/kit/.mozilla/Default User3/zlyw021b.slt/chrome/
     ** folder = /home/kit/.mozilla/Default User3/zlyw021b.slt/chrome/buk/
     ** addFile() for JAR returned: 0
     ** regChrome (skin) returned: 0
     [1/2]      Installing: /home/kit/.mozilla/Default User3/zlyw021b.slt/chrome/buk/buk.jar
     [2/2]      Register Skin: jar:file:///home/kit/.mozilla/Default%20User3/zlyw021b.slt/chrome/buk

     Install completed successfully  --  2006-09-29 22:29:41



Reproducible: Always

Steps to Reproduce:
1. Create install.js:

initInstall("buk", "/buk", "0.003");
var chrome_dir = getFolder ('Profile', 'chrome')
var flag   = PROFILE_CHROME;
var folder = getFolder (chrome_dir, "buk");
setPackageFolder(folder)

addFile("buk2buk", "chrome/buk.jar", folder,"")

registerChrome (SKIN | flag, getFolder(folder,"buk.jar"), "skin/")

performInstall();

2. create chrome/skin/contents.rdf

<?xml version="1.0"?>

<RDF:RDF xmlns:RDF="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
         xmlns:chrome="http://www.mozilla.org/rdf/chrome#">

<!-- comment -- comment -->

</RDF:RDF>

3. build .xpi

cd chrome ; rm -f buk.jar ; zip -r buk.jar skin ; cd ..
zip ../../buk.xpi chrome/buk.jar install.js

4. run seamonkey with fresh profile and try to install

Comment 1

[Benjamin Smedberg]

This is not well-formed XML, and Mozilla is failing correctly. Please look up the XML specification for comments, where double-dashes delimit comment and text data.