354977 - Revert the patch in bug 239017 (date column uses long dates)

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox, defect)

Description

[Adam Guthrie]

Contrary to bug 239017 comment 1, I think column width is an issue. This patch accomplishes very little, and it makes the dates column overly wide taking away from other columns' space.

The full date is listed at the top of each page in the format "tree: Firefox (2006-09-30 13:21 PDT)", for example. I don't think we need to put the full date next to each hourly block.

This is going to become highly visible when justdave updates tinderbox to use CVS (which should be happening shortly).

Comment 1

[cls]

Exactly why do you think column width is an issue?  If you have a tree with more than 5 or so clients (like SeaMonkey-Ports used to be), then you're going to have to scroll across to see all of the columsn.  Adding 5 chars to the date column doesn't "take away" from anyone's space.  We have no constraints to make the main page fit into a single arbritrary width so I see no merit to this bug.

If you think the date column is overly wide, then you should consider taking out the seconds resolution.  It will be a very rare occurance where the seconds make a difference.  The year is more important IMO.

The current full date listed at the top of the page means very little when you have the ability to leap backwards multiple weeks (up to 52) at a time.

Comment 2

[Bill Gianopoulos [:WG9s]]

Just change the ' ' between the date and time to a plain old space ' ', and that fixes the ambiguous time issue without making the column overly wide.  It just wraps between the date and time.

Comment 3

[timeless]

i'm all for dropping seconds.

Comment 4

[aja+bugzilla]

FWIW, you could leave the year and seconds off, and add a title with full ISO8601 dateTime format < http://www.w3.org/TR/NOTE-datetime > in it, e.g.:

<abbr class="dtstart" title="2006-12-31T23:59:59.9Z-08:00">23:59</abbr> 

Note use of hCalendar-compliant class: http://microformats.org/wiki/hcalendar

Comment 5

[cls]

Using a space instead of &nbsp causes the time to appear slightly offset under the date when it wraps.  IMO, that looks worse than a long date.  

I'm waiting to hear why column width is suddenly an issue.

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to comment #5)
> Using a space instead of &nbsp causes the time to appear slightly offset under
> the date when it wraps.  IMO, that looks worse than a long date.  

That could  be fixed by forcing a wrap with a <br> rather than a space I suppose.  I thought that might look uglier to something using a script to parse this page, but I suppose if it can handle a &nbsp; that really should not be an issue.

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to comment #5)
> I'm waiting to hear why column width is suddenly an issue.
> 
Sorry for spam, I should have done this in one comment.  I don't personally think column width is that big a deal.  The issue is with the number of tinderbox systems that can be displayed on a single page at a given screen resolution without requiring horizontal scrolling.