355097 - Crash with alert and setTimeout(goQuitApplication, 1000)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

This testcase sometimes (~30% of the time) triggers a sg:critical crash.

This might be related to bug 52209 and/or bug 355069.

Don't pay too much attention to the string concatenation in the testcase, that might just be a distraction.

Comment 1

[Jesse Ruderman]

Attachment: testcase (requires chrome privs)

This testcase requires chrome privileges in order to call goQuitApplication.  If you view it locally there's probably some way to grant it the privileges it needs.

Comment 2

[Jesse Ruderman]

Attachment: stack trace from a mac nightly

This stack shows Firefox dereferencing a random address.  Sometimes it jumps to a random address instead.

Comment 3

[Jesse Ruderman]

This reminds me of bug 339683.

Comment 4

[Jesse Ruderman]

Cmd+Q (in the same window or in another window) does not cause similar problems, so maybe goQuitApplication is special and this bug is invalid.

Comment 5

[Boris Zbarsky [:bzbarsky]]

The real issue here, imho, is that that timeout runs while the alert is up.  That said, if we really care we could try to figure out how shutdown is messing up here...

Does doing the quit in window A while an alert is up for window B crash?  I'd bet not.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> we could try to figure out

Which I guess is a roundabout way of saying "not I"....

Comment 7

[Jesse Ruderman]

(In reply to comment #5)
> Does doing the quit in window A while an alert is up for window B crash?  I'd
> bet not.

Yes.  It didn't crash on the first two tries, but on the third try I got:

Thread 0 Crashed:
0    0 + -2080374784
1    DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 692

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK, I see.  So I guess hiding any sheet after its window is dead is generally crashy...  Might want to get Mac widget folks to look into it.

Comment 9

[Jesse Ruderman]

I think this is the same as bug 355273.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Yeah, for sure.

Comment 11

[Jesse Ruderman]

The testcase no longer causes a crash for me on trunk.  It seems like the quit doesn't go through until the JavaScript finishes.

Comment 12

[Johnny Stenback (:jst)]

JS timers no longer fire while modal dialogs are open (see bug 52209). This may still be triggerable using more than one top-level window though, as I believe timeouts can still fire in a window while an alert is open in another window.

Comment 13

[Jesse Ruderman]

I tried that and it didn't crash.  Maybe I didn't try it enough times, though (comment 0 says it's only 30% reproducible).

Comment 14

[Mats Palmgren (inactive)]

If I open two windows and load the testcase locally then I can reproduce
the crash in a recent 1.8 branch debug build (== 2.0.0.5 RC2 or so).
The patch in bug 355273 fixes it for me.

Comment 15

[Mats Palmgren (inactive)]

-> FIXED (by bug 355273)

Comment 16

[Daniel Veditz [:dveditz]]

Fix for bug 355273 landed in 1.8.1.8