355143 - toolbarbutton type="menu" layout problem

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Ben Mills]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Firefox 2.0 RC1

The problem relates to creating a toolbarbutton with type="menu".  In Firefox 1.x, the dropmarker was to the right of the image and text.  In Firefox 2.0, the dropmarker sits under the image and text and looks very awkward.

I found a fix on the web which binds the toolbarbutton to chrome://global/content/bindings/toolbarbutton.xml#menu-vertical.  This works, but breaks things in Firefox 1.5.  In Firefox 1.5, the correct binding ID seems to be "menu-orient".  It seems to me that this binding should be automatic and that the default layout in Firefox 2.0 is a bug.

Reproducible: Always

Steps to Reproduce:
1. Overlay the main toolbar to add a toolbarbutton of type="menu"
2. View toolbar with icons and text
3. Note position of dropmarker

Actual Results:  
Dropmarker sits under the image and text

Expected Results:  
Dropmarker should sit to the right of the image and text

Comment 1

[Nickolay_Ponomarev]

Is this still a problem in trunk builds?

If yes, could you attach a standalone testcase, possibly with screenshots if the testcase alone doesn't make the problem clear. 

Or if this is Firefox theme-specific issue, this shouldn't be in the "Toolkit" component and a clearer explanation of the issue should be given.

Steps to reproduce requiring people to write and set up overlays are not very likely to be followed...

I know of a bug where type="menu-button" toolbarbuttons have their text slightly higher than regular toolbarbuttons, is this bug different?

Comment 2

[alta88]

this is definitely still a problem in latest 3.1pre trunk.

the binding here: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#133

needs to be changed to "menu-vertical" from "menu", if someone who has mozilla-central hg cloned could do this..