355167 - Make bookmark item tooltips have title and url like bookmark buttons

Status: VERIFIED WONTFIX

(Camino Graveyard :: Bookmarks, defect)

Description

[froodian (Ian Leue)]

Spawned from http://forums.mozillazine.org/viewtopic.php?t=470301:

1. Cmd-B
2. Hover over a bookmark

Right now we have

url
description

as the tooltip.  It seems like having

Title
—
url

would be far more useful for most people, and would mimic the way we format tooltips for bookmark buttons and the back/forward toolbar buttons.

Comment 1

[froodian (Ian Leue)]

Attachment: Patch

This does what I described.  One thing we should think about is what we want to do about tooltips for bookmark folders.  Right now I just leave it how it is (title \n description) but we should either have it just be title or give the em-dash and make it properly localized.

Comment 2

[froodian (Ian Leue)]

This would also make the following string changes (pseudo-diff):

- "BookmarkButtonTooltipFormat" = "%1$@\n—\n%2$@";  /* 1=title, 2=url */
- "BackButtonTooltipFormat" = "%1$@\n—\n%2$@";  /* 1=title, 2=url */
- "ForwardButtonTooltipFormat" = "%1$@\n—\n%2$@";  /* 1=title, 2=url */
+ "TitleAndURLTooltipFormat" = "%1$@\n—\n%2$@";  /* 1=title, 2=url */

Comment 3

[Stuart Morgan]

I don't think this is the right way to go; I think we should be fixing bug 315340 instead (it's not just about the location, it's about doing the expand-truncated-strings-in-place style tooltips; try hovering over something truncated in Finder column view, for example, to see what it's requesting).

Comment 4

[froodian (Ian Leue)]

So would it have separate tracking rects for URL and title columns (compounding the existing perf slowdown), or would you only be able to get tooltips for one or the other?  What I like about this solution is that it keeps tracking rects down and provides URL and title information.

Comment 5

[philippe (part-time)]

Attachment: screenshot

Unless something went wrong on my side, but this is what I get after applying that patch (trunk build).
The same happens to the tooltip for bookmarks on the bookmarkbar.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> Unless something went wrong on my side, but this is what I get after applying
> that patch (trunk build).
You missed the Localizable.strings change in comment 2 ;) (strings files are not diff-able)

Comment 7

[philippe (part-time)]

(In reply to comment #6)
> (In reply to comment #5)
> > Unless something went wrong on my side, but this is what I get after applying
> > that patch (trunk build).
> You missed the Localizable.strings change in comment 2 ;) (strings files are
> not diff-able)
> 

Ah, that explains it. Will try again later.

Comment 8

[Håkan Waara]

Comment on attachment 240989 [details] [diff] [review]
Patch

I agree with Stuart here. I think we should truncate the items in these columns, and then show tooltips only when something is truncated. When the whole item is visible, a tooltip is not much useful anyway.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Per the meeting, we're going to do bug 315340 instead.